- --
Viewing Issue Advanced Details
ID | Category [?] | Severity [?] | Reproducibility | Date Submitted | Last Update |
---|---|---|---|---|---|
02139 | Misc. | Typo | Have not tried | Aug 21, 2008, 04:47 | Aug 22, 2008, 02:34 |
Tester | Robbbert | View Status | Public | Platform | MAME (Self-compiled) |
Assigned To | aaron | Resolution | Fixed | OS | Windows XP/Vista 32-bit |
Status [?] | Resolved | Driver | |||
Version | 0.127 | Fixed in Version | 0.127u1 | Build | Normal |
Fixed in Git Commit | Github Pull Request # | ||||
Summary | 02139: In audio/system16.c, there is a reference to REGION_SOUND1 | ||||
Description |
In mame/audio/system16.c, there is a reference to REGION_SOUND1. The function name is sys16_7751_sh_rom_r For some reason there was no error with a normal MAME compile, but it showed up while converting misfitmame to 0.127 By changing REGION_SOUND1 to "sound", the compile continued ok. I did not test to see if any games stopped working. |
||||
Steps To Reproduce | |||||
Additional Information | |||||
Github Commit | |||||
Flags | |||||
Regression Version | |||||
Affected Sets / Systems | |||||
Attached Files
|
|||||
Relationships
There are no relationship linked to this issue. |
Notes
2
No.02144
etabeta Developer
Aug 21, 2008, 05:47
|
compiler doesn't complain simply because no game uses it in MAME ;) are you sure you need it in Misfit? maybe you could take a look to segas16a.c/segas16b.c for the correct replacement. anyway, the reference is there and either the handler should be removed (because unused) or the tag has to be used instead |
---|---|
No.02149
Robbbert Senior Tester
Aug 21, 2008, 07:06
edited on: Aug 21, 2008, 07:21 |
You're right, it's not used anywhere, not even by misfit. In fact, all I did was get the mame source, add the one romset needed for misfit, and upon compiling, the error appeared. Just now I commented the function out, and it still compiled ok. So, the unused function may as well be removed. |