02157: ckongg: Coinage settings shown on screen don't correspond to actual settings

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
02157	DIP/Input	Trivial	Always	Aug 24, 2008, 04:37	Jan 10, 2010, 23:25

Tester	etabeta	View Status	Public	Platform
Assigned To	stephh	Resolution	Fixed	OS
Status [?]	Resolved			Driver	galaxian/galaxold.cpp
Version	0.127	Fixed in Version	0.136u1	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	02157: ckongg: Coinage settings shown on screen don't correspond to actual settings
Description	While fixing 02154, I noticed that coinage settings shown on the score screen does not corresponds to the actual ones. to see this in 0.127: 1. let the unused dip to OFF, and set coinage to 1/1. The shown setting is 1 Coin to play as P1 but if you insert a coin with '5' it gives you 2 credits. ~~2. set the unused dip to ON and the coinage to 1/1. The shown setting is 3 Coin to play as P1, but the game accept only 1 Coin (and it gives 1 Credit for this)~~ (if it's ON the settings correspond to the ones on screen) This is 99% due to the conversion from ckong hardware (in cclimber.c) to galaxian hardware. However, it would be nice to have a confirmation of the behavior.
Steps To Reproduce
Additional Information
Github Commit

Flags	Verified with Code
Regression Version
Affected Sets / Systems	ckongg

Attached Files

No.02199 Fujix Administrator Aug 24, 2008, 09:46	Checked out all cases: Unused: OFF - Coinage: 2 Coins / 1 Credit -> 4 Credits / 1 Coin - Coinage: 1 Coin / 1 Credit -> 2 Credits / 1 coin - Coinage: Freeplay -> 4 Credits / 1 Coin Unused: ON - Coinage: 2 Coins / 1 Credit -> 1 Credit / 5 Coins - Coinage: 1 Coin / 1 Credit -> 1 Credit / 3 Coins - Coinage: Freeplay -> 4 Credits / 1 Coin / 5 Coins It seems the freeplay switch doesn't affect the coinage setting in fact.
No.02200 etabeta Developer Aug 24, 2008, 12:50 edited on: Aug 24, 2008, 14:32	oops, I guess you're right and unused ON gives 5 & 3 coins / 1 credit. I already sent a patch updating the coinage dips according to my comment to 02154, but it seems I was partially wrong. I'll update the patch with the values you find for Unused ON (the remaining part was already fixed ;) ) Anyway, this report was NOT for the coinage settings (already covered by 02154) but for the wrong displayed values!! ;)
No.02203 etabeta Developer Aug 24, 2008, 14:48	updated report as per new findings
No.05480 stephh Developer Jan 10, 2010, 23:23	Coinage displayed is in fact the number of coins needed to play a 1 or 2 players game. The problem was that the Dip Switches were still wrong (even after the supposed fix). I've updated the galaxold.c driver according to the Z80 code, so now everything shall be correct in 0.136u1 .