02710: spaceint, spaceintj: Corrupt screen in cocktail mode

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
02710	Flip Screen/Cocktail	Major	Always	Dec 5, 2008, 06:02	Nov 26, 2012, 09:59

Tester	Robbbert	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	Robbbert	Resolution	Fixed	OS
Status [?]	Resolved			Driver	stern/astinvad.cpp
Version	0.128	Fixed in Version	0.147u4	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	02710: spaceint, spaceintj: Corrupt screen in cocktail mode
Description	When it's the second player's turn in a cocktail game, the screen is messed up.
Steps To Reproduce
Additional Information	The VIDEO_UPDATE routine has no code to handle the flipped screen. spaceinj -> spaceintj in 0.133u1
Github Commit

Flags
Regression Version
Affected Sets / Systems	spaceint, spaceintj

Attached Files	spaceint.png (1,473 bytes) Dec 5, 2008, 06:02

No.03227 Robbbert Senior Tester Dec 5, 2008, 11:17	This works if someone would like to test.. static VIDEO_UPDATE( spaceint ) { const UINT8 color_prom = memory_region(screen->machine, "proms"); int offs; UINT8 data,color,y,x,c; offs_t n; if (screen_flip) { for (offs = 0; offs < videoram_size; offs++) { data = videoram[offs]; c = colorram[offs]; y = offs; x = ~offs >> 8 << 3; / this is almost certainly wrong / n = ((offs >> 5) & 0xf0) \| c; color = (color_prom[n]); plot_byte(bitmap, y, x, data, color); } } else { for (offs = 0; offs < videoram_size; offs++) { data = videoram[offs]; c = colorram[offs]; y = ~offs; x = offs >> 8 << 3; / this is almost certainly wrong */ n = ((~offs >> 5) & 0xf0) \| c; color = (color_prom[n]); plot_byte(bitmap, y, x, data, color); } } return 0; }
No.09100 Robbbert Senior Tester Nov 26, 2012, 09:57	Added flipscreen code copied from Misfitmame. Fixed at r19149.

No.03227

Robbbert

Senior Tester

Dec 5, 2008, 11:17

This works if someone would like to test..

static VIDEO_UPDATE( spaceint )
{
const UINT8 *color_prom = memory_region(screen->machine, "proms");
int offs;
UINT8 data,color,y,x,c;
offs_t n;

if (screen_flip)
{
for (offs = 0; offs < videoram_size; offs++)
{
data = videoram[offs];
c = colorram[offs];
y = offs;
x = ~offs >> 8 << 3;

/* this is almost certainly wrong */
n = ((offs >> 5) & 0xf0) | c;
color = (color_prom[n]);

plot_byte(bitmap, y, x, data, color);
}
}
else
{
for (offs = 0; offs < videoram_size; offs++)
{
data = videoram[offs];
c = colorram[offs];
y = ~offs;
x = offs >> 8 << 3;

/* this is almost certainly wrong */
n = ((~offs >> 5) & 0xf0) | c;
color = (color_prom[n]);

plot_byte(bitmap, y, x, data, color);
}
}

return 0;
}

No.09100

Robbbert

Senior Tester

Nov 26, 2012, 09:57

Added flipscreen code copied from Misfitmame. Fixed at r19149.