02735: firefox, firefoxa: -verifyrom fails to consider if a CHD is a BAD_DUMP

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
02735	Misc.	Minor	Always	Dec 11, 2008, 20:17	Dec 12, 2008, 17:21

Tester	Radwar	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	Invalid report	OS	Windows XP/Vista 32-bit
Status [?]	Closed			Driver	atari/firefox.cpp
Version	0.128u5	Fixed in Version		Build	I686
		Fixed in Git Commit		Github Pull Request #

Summary	02735: firefox, firefoxa: -verifyrom fails to consider if a CHD is a BAD_DUMP
Description	This looks alot like the same bug that affected carnevil. When I verify the CHD with CHDMAN -verify it says: MD5 & SHA1 verification successful ClrMAMEPro also fails to verify that the CHD is bad. But when I run the game, MAME tells me that either the Roms or the CHD is bad. When I exit MAME, I get the following error.: firefox.chd WRONG CHECKSUMS: EXPECTED: FOUND: SHA1(b500a834fa505e4c0649d8e5e6b7d40d4deef48d) MD5 (73fb69fd20adf2800b28dc1ab58be2d4) Weird thing is that in version 0128u4, I didn't get any graphics at all from the CHD, like I didn't have the firefox.chd file. But in version 0128u5, the game seem to run fine. Unless the screenshot shows graphical problems I'm not aware of. (Never played this game before) Also, I should also note that when MAME 0128u4 was out, the romsets were affected aswell. I had a bad at-6-1_a.bin rom and ClrMAMEPro couldn't detect it, but MAME did when exited the game. I replaced the file and MAME was satisfied. I can't verify if this problem is still present in 0128u5 because I don't have the bad rom anymore.
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	firefox, firefoxa

Attached Files	firefox.png (509,633 bytes) Dec 11, 2008, 20:17

No.03284 Fujix Administrator Dec 12, 2008, 02:30 edited on: Dec 12, 2008, 02:32	The screen shot shows interlacing artifacts, it should be a correct work and doesn't have to do with bad or corrupted CHD. Checksums of my firefox.chd are MD5: 9eeca07c3fcdc8f9f1cf4d14085d1ae3 SHA1: 23df739108c2653226446ea4c662f0ef0ec5b3c0 and chdman result: chdman - MAME Compressed Hunks of Data (CHD) manager 0.128u3 (Nov 10 2008) Input file: firefox.chd MD5 verification successful!... SHA1 verification successful! It seems that the checksums are different from the source code expects, but MAME doesn't return the error when I exit it in u5, weird.. What are checksums of your chd?
No.03285 Radwar Tester Dec 12, 2008, 03:47	I've written them in my report.
No.03286 Fujix Administrator Dec 12, 2008, 11:15	Sorry, my mistake.
No.03289 aaron Developer Dec 12, 2008, 14:56	A CHD can verify fine with chdman and still be bad in the game. In MAME 0.128u4 there were no checksums for the firefox.chd. In MAME 0.128u5 they were added. I don't see any bug here.
No.03290 Radwar Tester Dec 12, 2008, 16:36	Oh ok, sorry my bad.