02736: sicv, sisv, sisv2: These colour games have the green/red overlay applied

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
02736	Color/Palette	Minor	Always	Dec 12, 2008, 11:57	Dec 12, 2008, 13:49

Tester	Robbbert	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	No change required	OS	Windows XP/Vista 32-bit
Status [?]	Closed			Driver	midw8080/8080bw.cpp
Version	0.128	Fixed in Version		Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	02736: sicv, sisv, sisv2: These colour games have the green/red overlay applied
Description	Because "invaders" is the parent of the affected sets, the artwork layout is automatically applied to the children and can only be turned off in the game's "Video Options". The overlay is applied to all the children, regardless of if GAME or GAMEL macro is used. This, I believe, to be incorrect behavior. To test the theory, I made "sicv" stand alone, and the problem went away. Versions 0.127 and 0.128 were tested.
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems	sicv, sisv, sisv2

Attached Files	sisv.png (1,643 bytes) Dec 12, 2008, 11:57

No.03287 Tafoid Administrator Dec 12, 2008, 12:35	I'm not convinced this is a way to correct this problem. This appears to be a layout problem with the invaders artwork package from Mr. Do's site. If you take that completely out of the equation - the screen seems to look normally colored. Setting this as a separate parent/clone is problematic, IMHO. I suppose what would need to be done is to ignore external artwork changes if there is a built in .LAY controlling overlay for a game/clones already?
No.03288 Robbbert Senior Tester Dec 12, 2008, 13:49	I wasn't advocating breaking the parent/child relationship - it was just used as an example. As far as external artwork goes, you are correct, and I didn't think of it. Which means my initial statement was all wrong. External artwork on a parent always affects the children, unless a new artwork file exists. In this particular case it causes a conflict but I guess there's not really any way out of it. You may as well close this.

No.03287

Tafoid

Administrator

Dec 12, 2008, 12:35

I'm not convinced this is a way to correct this problem. This appears to be a layout problem with the invaders artwork package from Mr. Do's site. If you take that completely out of the equation - the screen seems to look normally colored. Setting this as a separate parent/clone is problematic, IMHO.

I suppose what would need to be done is to ignore external artwork changes if there is a built in .LAY controlling overlay for a game/clones already?

No.03288

Robbbert

Senior Tester

Dec 12, 2008, 13:49

I wasn't advocating breaking the parent/child relationship - it was just used as an example.

As far as external artwork goes, you are correct, and I didn't think of it.

Which means my initial statement was all wrong.

External artwork on a parent always affects the children, unless a new artwork file exists.

In this particular case it causes a conflict but I guess there's not really any way out of it.

You may as well close this.