02827: 64-bit build fails

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
02827	Compiling	Major	Always	Jan 15, 2009, 10:55	Jan 27, 2009, 18:14

Tester	nostos	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	Fixed	OS	Windows XP/Vista 64-bit
Status [?]	Resolved			Driver
Version	0.129u1	Fixed in Version	0.129u3	Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	02827: 64-bit build fails
Description	Compiling src/mame/machine/balsente.c... balsente.c src\mame\machine\balsente.c(186) : error C2220: warning treated as error - no 'o bject' file generated src\mame\machine\balsente.c(186) : warning C4090: 'function' : different 'const' qualifiers mingw32-make: *** [obj/windows/vmame/mame/machine/balsente.o] Error 2
Steps To Reproduce
Additional Information
Github Commit

Flags	64-bit specific
Regression Version
Affected Sets / Systems

Attached Files	vscompile.zip (633 bytes) Jan 27, 2009, 18:13

No.03619 john_iv Senior Tester Jan 22, 2009, 17:04	Continues to plague .129u2.
No.03627 john_iv Senior Tester Jan 23, 2009, 01:47	As RB pointed out this is Visual Studio specific in x64, his GCC 64 compiles work w/ -werror. Workaround currently is to disable -werror in the main makefile.
No.03631 Tafoid Administrator Jan 23, 2009, 18:00	Deleted attached fix. Will wait for a proper one.
No.03656 Roman Senior Tester Jan 26, 2009, 20:16 edited on: Jan 26, 2009, 22:09	here's a proper one for timekpr and balsente which should fix all VS warnings diff -Nru old\src/emu/machine/timekpr.c new\src/emu/machine/timekpr.c --- old\src/emu/machine/timekpr.c 2009-01-26 23:05:50.000000000 +0100 +++ new\src/emu/machine/timekpr.c 2009-01-26 20:59:05.000000000 +0100 @@ -348,7 +348,7 @@ c->offset_flags = -1; c->size = 0x800; - return DEVICE_START_CALL( timekeeper ); + DEVICE_START_CALL( timekeeper ); } static DEVICE_START(m48t35) @@ -367,7 +367,7 @@ c->offset_flags = -1; c->size = 0x8000; - return DEVICE_START_CALL( timekeeper ); + DEVICE_START_CALL( timekeeper ); } static DEVICE_START(m48t58) @@ -386,7 +386,7 @@ c->offset_flags = -1; c->size = 0x2000; - return DEVICE_START_CALL( timekeeper ); + DEVICE_START_CALL( timekeeper ); } static DEVICE_START(mk48t08) @@ -405,7 +405,7 @@ c->offset_flags = 0x1ff0; c->size = 0x2000; - return DEVICE_START_CALL( timekeeper ); + DEVICE_START_CALL( timekeeper ); } /------------------------------------------------- diff -Nru old\src/mame/machine/balsente.c new\src/mame/machine/balsente.c --- old\src/mame/machine/balsente.c 2009-01-26 23:05:47.000000000 +0100 +++ new\src/mame/machine/balsente.c 2009-01-26 20:44:58.000000000 +0100 @@ -183,7 +183,7 @@ / reset the noise generator / memset(noise_position, 0, sizeof(noise_position)); - memset(cem_device, 0, sizeof(cem_device)); + memset((device_config )cem_device, 0, sizeof(cem_device)); /* point the banks to bank 0 */ numbanks = (memory_region_length(machine, "main") > 0x40000) ? 16 : 8;
No.03662 Tafoid Administrator Jan 27, 2009, 18:14	Fix sent by Roman for 0.129u3