02873: Many sets in system1.c: Missing text layer

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
02873	Graphics	Major	Always	Jan 24, 2009, 21:59	Jan 25, 2009, 13:48

Tester	Kale	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	Haze	Resolution	Fixed	OS	Windows XP/Vista 32-bit
Status [?]	Resolved			Driver	sega/system1.cpp
Version	0.129u2	Fixed in Version	0.129u3	Build	Normal
		Fixed in Git Commit		Github Pull Request #

Summary	02873: Many sets in system1.c: Missing text layer
Description	Text layer seems to not update it constantly in some games in the Sega System 1 driver.
Steps To Reproduce	4dwarrio, blckgalb, wboy, myhero, raflesia, possibly others Just run one of the aforementioned games.
Additional Information	Changes in 0.130u3: < Block Gal (bootleg) [name: blckgalb - parent: blockgal] > Block Gal (bootleg) [name: blockgalb - parent: blockgal]
Github Commit

Flags
Regression Version	0.129u1
Affected Sets / Systems	Many sets in system1.c

Attached Files	0000.png (5,180 bytes) Jan 24, 2009, 21:59
	0001.png (2,684 bytes) Jan 24, 2009, 22:00
	4dwarrio.png (6,529 bytes) Jan 24, 2009, 22:01

No.03642 Kale Developer Jan 24, 2009, 22:01	Thanks to Swos and Scuore for pointing this out.
No.03643 Tafoid Administrator Jan 24, 2009, 22:13	Confirmed behavior and regression
No.03644 Kale Developer Jan 24, 2009, 22:34	Conditional check at line 393 of video/system1.c is the guilty for this: "if (machine->gfx[0]->pen_usage[code] & ~1)" I'm of the opinion that optimizations for this HW aren't really needed in 2009 anyway. Time to remove them?