03107: Drivers using emu/sound/psx.c: Sound effects are cut abruptly/clipped

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
03107	Sound	Minor	Always	Apr 13, 2009, 08:30	Feb 13, 2011, 01:03

Tester	Scagazza	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	R. Belmont	Resolution	Fixed	OS
Status [?]	Resolved			Driver
Version	0.130u3	Fixed in Version	0.141u3	Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	03107: Drivers using emu/sound/psx.c: Sound effects are cut abruptly/clipped
Description	Some games' sound effects are cut too quickly and do not sustain when they should.
Steps To Reproduce	Some games which are obvious examples: shanghss - taitogn.c brvblade - zn.c
Additional Information	Drivers possibly effected: konamigv.c ksys573.c taitogn.c zn.c
Github Commit

Flags
Regression Version	0.130u3
Affected Sets / Systems	Drivers using emu/sound/psx.c

Attached Files

No.04201 Tafoid Administrator Apr 13, 2009, 12:41	I suspect we'll get a lot of reports like this. With the implementation of some control over the PSX SPU, we have some cases of where sound effects might be abruptly cut off in exchange of attempting to get rid of the looping forever behavior. I'm setting this up as an all-inclusive report to cover the odd cases.. so when accurate functioning of the SPU, we can resolve this.
No.04203 Haze Senior Tester Apr 13, 2009, 16:17	Indeed, it will need proper SPU envelope support. Previously keyoff was ignored completely, not implemented at all. Now keyoff causes the sound to end, but any decay etc. is ignored so sounds may appear cut short. Assuming nobody else does it, I still have it on my todo list with the pSX source as a near definitive reference on the matter.
No.04718 Coadey Tester Jul 27, 2009, 03:15	Still an issue as of 0.133 for beastrzr and bldyror2 (all SPU samples are clipped after a few ms).
No.04720 Haze Senior Tester Jul 27, 2009, 10:58	Well nobody has claimed it to be fixed. Bumping issues for no reason is only likely to get your account disabled. Right now you have a choice between a) Sounds which cut off early and a few which loop forever b) Many sounds which loop forever and it will remain that way until somebody writes a full bug-free implementation of the SPU envelopes.