- --
 
      Viewing Issue Advanced Details
    
  
      
      [ Jump to Notes ]       
          
    | ID | Category [?] | Severity [?] | Reproducibility | Date Submitted | Last Update | 
|---|---|---|---|---|---|
| 03255 | Compiling | Minor | Always | Jun 10, 2009, 22:57 | Jun 11, 2009, 02:56 | 
| Tester | hap | View Status | Public | Platform | MAME (Self-compiled) | 
| Assigned To | Resolution | Fixed | OS | Windows XP/Vista/7 32-bit | |
| Status [?] | Resolved | Driver | |||
| Version | 0.132 | Fixed in Version | 0.132u1 | Build | Normal | 
| Fixed in Git Commit | Github Pull Request # | ||||
| Summary | 03255: Compile errors with GCC 4.4 (SDLMAME specific) | ||||
| Description | 
          mix logical NOT with bitwise AND, simple fix It makes sense to change ! to ~ see notes  | 
      ||||
| Steps To Reproduce | |||||
| Additional Information | |||||
| Github Commit | |||||
| Flags | |||||
| Regression Version | |||||
| Affected Sets / Systems | |||||
| 
               Attached Files 
             | 
            |||||
      Relationships
		
    
  | There are no relationship linked to this issue. | 
      Notes
      
    
  8
    | 
             No.04478 
            hap             Developer 
            
            Jun 10, 2009, 23:10 
                         | 
          
            arabian.c driver: src/mame/video/arabian.c: In function 'palette_init_arabian': src/mame/video/arabian.c:89: error: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' src/mame/video/arabian.c:120: error: suggest parentheses around operand of '!' o r change '&' to '&&' or '!' to '~' src/mame/video/arabian.c:141: error: suggest parentheses around operand of '!' o r change '&' to '&&' or '!' to '~' mingw32-make: *** [obj/windows/mame/mame/video/arabian.o] Error 1  | 
        
|---|---|
| 
             No.04479 
            hap             Developer 
            
            Jun 10, 2009, 23:11 
                         | 
          
            scramble.c driver: src/mame/machine/scramble.c: In function 'driver_init_billiard': src/mame/machine/scramble.c:607: error: suggest parentheses around operand of '! ' or change '&' to '&&' or '!' to '~' src/mame/machine/scramble.c:608: error: suggest parentheses around operand of '! ' or change '&' to '&&' or '!' to '~' src/mame/machine/scramble.c:611: error: suggest parentheses around operand of '! ' or change '&' to '&&' or '!' to '~' mingw32-make: *** [obj/windows/mame/mame/machine/scramble.o] Error 1  | 
        
| 
             No.04480 
            hap             Developer 
            
            Jun 10, 2009, 23:16 
                         | 
          
            cosmic.c driver: for line 347, change: if ((!(hc & va) & (vb ^ hb_)) to if ((!(hc & va) && (vb ^ hb_)) src/mame/video/cosmic.c: In function 'cosmica_draw_starfield': src/mame/video/cosmic.c:347: error: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' src/mame/video/cosmic.c: In function 'nomnlnd_draw_background': src/mame/video/cosmic.c:485: error: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' src/mame/video/cosmic.c:488: error: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' src/mame/video/cosmic.c:519: error: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' mingw32-make: *** [obj/windows/mame/mame/video/cosmic.o] Error 1  | 
        
| 
             No.04481 
            hap             Developer 
            
            Jun 10, 2009, 23:20 
                         | 
          
            aerofgt.c driver: parentheses around !chip_disabled_pri src/mame/video/aerofgt.c: In function 'turbofrc_draw_sprites': src/mame/video/aerofgt.c:419: error: suggest parentheses around operand of '!' o r change '&' to '&&' or '!' to '~' src/mame/video/aerofgt.c: In function 'spinlbrk_draw_sprites': src/mame/video/aerofgt.c:494: error: suggest parentheses around operand of '!' o r change '&' to '&&' or '!' to '~' src/mame/video/aerofgt.c: In function 'aerfboo2_draw_sprites': src/mame/video/aerofgt.c:570: error: suggest parentheses around operand of '!' o r change '&' to '&&' or '!' to '~' mingw32-make: *** [obj/windows/mame/mame/video/aerofgt.o] Error 1  | 
        
| 
             No.04482 
            hap             Developer 
            
            Jun 10, 2009, 23:22 
                         | 
          
            thayers.c driver, change & to && src/mame/drivers/thayers.c: In function 'control2_w': src/mame/drivers/thayers.c:303: error: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' mingw32-make: *** [obj/windows/mame/mame/drivers/thayers.o] Error 1  | 
        
| 
             No.04483 
            Tafoid             Administrator 
            
            Jun 10, 2009, 23:26 
                         | 
          I think this would be best served and easier read as a single attached text file - rather than different notes. I believe R Belmont has been making changes for GCC 4.4 recently. Some of these might already be done. | 
| 
             No.04485 
            hap             Developer 
            
            Jun 10, 2009, 23:53 
                         | 
          
            Let's wait on a comment by R.Belmont then =) I had a few of these "! mixed with & errors" in 74181.c and 74148.c too, but didn't bother looking how to fix them properly.  | 
        
| 
             No.04486 
            R. Belmont             Developer 
            
            Jun 11, 2009, 02:56 
                         | 
          Fixed for 0.132u1 using "gcc (GCC) 4.4.0 20090506 (Red Hat 4.4.0-4)" which ships with Fedora 11. I should throw in some yelling at the submitter for the unsupported configuration (GCC 4.4 is supported only for SDLMAME targets, not baseline on 32-bit Windows) but consider that implied :P |