Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
03422 Graphics Minor Always Sep 4, 2009, 02:20 Sep 4, 2009, 17:43
Tester M.A.S.H. View Status Public Platform MAME (Self-compiled)
Assigned To M.A.S.H. Resolution Fixed OS Windows XP (32-bit)
Status [?] Resolved Driver galaxold.cpp
Version 0.133u4 Fixed in Version 0.133u5 Build Normal
Summary 03422: porter: Missing in-game graphics
Description MooglyGuy merged in MAME 0.131u1 the memory maps in the Galaxold driver
from:

static ADDRESS_MAP_START( mooncrst_readmem, ADDRESS_SPACE_PROGRAM, 8 )
AM_RANGE(0x0000, 0x5fff) AM_READ(SMH_ROM)
AM_RANGE(0x8000, 0x87ff) AM_READ(SMH_RAM)
AM_RANGE(0x9000, 0x93ff) AM_READ(SMH_RAM)
AM_RANGE(0x9400, 0x97ff) AM_READ(galaxold_videoram_r)
AM_RANGE(0x9800, 0x98ff) AM_READ(SMH_RAM)
AM_RANGE(0xa000, 0xa000) AM_READ_PORT("IN0")
AM_RANGE(0xa800, 0xa800) AM_READ_PORT("IN1")
AM_RANGE(0xb000, 0xb000) AM_READ_PORT("DSW0")
AM_RANGE(0xb800, 0xb800) AM_READ(watchdog_reset_r)
ADDRESS_MAP_END

static ADDRESS_MAP_START( mooncrst_writemem, ADDRESS_SPACE_PROGRAM, 8 )
AM_RANGE(0x0000, 0x5fff) AM_WRITE(SMH_ROM)
AM_RANGE(0x8000, 0x87ff) AM_WRITE(SMH_RAM)
AM_RANGE(0x9000, 0x93ff) AM_WRITE(galaxold_videoram_w) AM_BASE(&galaxold_videoram)
AM_RANGE(0x9800, 0x983f) AM_WRITE(galaxold_attributesram_w) AM_BASE(&galaxold_attributesram)
AM_RANGE(0x9840, 0x985f) AM_WRITE(SMH_RAM) AM_BASE(&galaxold_spriteram) AM_SIZE(&galaxold_spriteram_size)
AM_RANGE(0x9860, 0x987f) AM_WRITE(SMH_RAM) AM_BASE(&galaxold_bulletsram) AM_SIZE(&galaxold_bulletsram_size)
AM_RANGE(0x9880, 0x98ff) AM_WRITE(SMH_RAM)
AM_RANGE(0xa003, 0xa003) AM_WRITE(galaxold_coin_counter_w)
AM_RANGE(0xa004, 0xa007) AM_WRITE(galaxian_lfo_freq_w)
AM_RANGE(0xa800, 0xa802) AM_WRITE(galaxian_background_enable_w)
AM_RANGE(0xa803, 0xa803) AM_WRITE(galaxian_noise_enable_w)
AM_RANGE(0xa805, 0xa805) AM_WRITE(galaxian_shoot_enable_w)
AM_RANGE(0xa806, 0xa807) AM_WRITE(galaxian_vol_w)
AM_RANGE(0xb000, 0xb000) AM_WRITE(galaxold_nmi_enable_w)
AM_RANGE(0xb004, 0xb004) AM_WRITE(galaxold_stars_enable_w)
AM_RANGE(0xb006, 0xb006) AM_WRITE(galaxold_flip_screen_x_w)
AM_RANGE(0xb007, 0xb007) AM_WRITE(galaxold_flip_screen_y_w)
AM_RANGE(0xb800, 0xb800) AM_WRITE(galaxian_pitch_w)
ADDRESS_MAP_END

to

static ADDRESS_MAP_START( mooncrst_map, ADDRESS_SPACE_PROGRAM, 8 )
AM_RANGE(0x0000, 0x5fff) AM_ROM
AM_RANGE(0x8000, 0x87ff) AM_RAM
AM_RANGE(0x9000, 0x93ff) AM_WRITE(galaxold_videoram_w) AM_BASE(&galaxold_videoram)
AM_RANGE(0x9400, 0x97ff) AM_READ(galaxold_videoram_r)
AM_RANGE(0x9800, 0x983f) AM_RAM_WRITE(galaxold_attributesram_w) AM_BASE(&galaxold_attributesram)
AM_RANGE(0x9840, 0x985f) AM_RAM AM_BASE(&galaxold_spriteram) AM_SIZE(&galaxold_spriteram_size)
AM_RANGE(0x9860, 0x987f) AM_RAM AM_BASE(&galaxold_bulletsram) AM_SIZE(&galaxold_bulletsram_size)
AM_RANGE(0x9880, 0x98ff) AM_RAM
AM_RANGE(0xa000, 0xa000) AM_READ_PORT("IN0")
AM_RANGE(0xa003, 0xa003) AM_WRITE(galaxold_coin_counter_w)
AM_RANGE(0xa004, 0xa007) AM_WRITE(galaxian_lfo_freq_w)
AM_RANGE(0xa800, 0xa800) AM_READ_PORT("IN1")
AM_RANGE(0xa800, 0xa802) AM_WRITE(galaxian_background_enable_w)
AM_RANGE(0xa803, 0xa803) AM_WRITE(galaxian_noise_enable_w)
AM_RANGE(0xa805, 0xa805) AM_WRITE(galaxian_shoot_enable_w)
AM_RANGE(0xa806, 0xa807) AM_WRITE(galaxian_vol_w)
AM_RANGE(0xb000, 0xb000) AM_READ_PORT("DSW0") AM_WRITE(galaxold_nmi_enable_w)
AM_RANGE(0xb004, 0xb004) AM_WRITE(galaxold_stars_enable_w)
AM_RANGE(0xb006, 0xb006) AM_WRITE(galaxold_flip_screen_x_w)
AM_RANGE(0xb007, 0xb007) AM_WRITE(galaxold_flip_screen_y_w)
AM_RANGE(0xb800, 0xb800) AM_READWRITE(watchdog_reset_r, galaxian_pitch_w)
ADDRESS_MAP_END


and forgot to add the READ(RAM) from 0x9000-0x93ff and 0x9800-0x983f.
To fixed this replaced line 429 from

AM_RANGE(0x9000, 0x93ff) AM_WRITE(galaxold_videoram_w) AM_BASE(&galaxold_videoram)
to
AM_RANGE(0x9000, 0x93ff) AM_RAM AM_WRITE(galaxold_videoram_w) AM_BASE(&galaxold_videoram)

and line 431 from

AM_RANGE(0x9800, 0x983f) AM_RAM_WRITE(galaxold_attributesram_w) AM_BASE(&galaxold_attributesram)
to
AM_RANGE(0x9800, 0x983f) AM_RAM AM_RAM_WRITE(galaxold_attributesram_w) AM_BASE(&galaxold_attributesram)
Steps To Reproduce
Additional Information
Flags
Regression Version 0.131u1
Affected Sets / Systems porter
Attached Files
png file icon porter-1.png (2,515 bytes) Sep 4, 2009, 02:20
png file icon porter-2.png (2,190 bytes) Sep 4, 2009, 02:21
Relationships
There are no relationship linked to this issue.
Notes
1
User avatar
No.04906
Tafoid
Administrator
Sep 4, 2009, 17:31
I believe the second map change is unneeded/redundant. The first one, in fact, fixes the regressed graphic issues.