Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
03729 Color/Palette Minor Always Feb 13, 2010, 00:20 Apr 30, 2022, 11:18
Tester M.A.S.H. View Status Public Platform
Assigned To Robbbert Resolution Fixed OS
Status [?] Resolved Driver galaxian.cpp
Version 0.136u2 Fixed in Version 0.244 Build
Fixed in Git Commit 90c2542 Github Pull Request #
Summary 03729: gmgalax: Wrong colors
Description The colors in Ghostmuncher Galaxian (bootleg) are wrong since MAME 0.124u1.
See snapshots from MAME 0.124 and MAME 0.136u2.
Steps To Reproduce Start gmgalax. Select Galaxian in the dipswitch menu and start the game.
Additional Information The video driver for gmgalax was changed in MAME 0.124u1 from:

static void gmgalax_modify_charcode(UINT16 *code,UINT8 x);
static void gmgalax_modify_spritecode(UINT8 *spriteram,int *code,int *flipx,int *flipy,int offs);
static void gmgalax_modify_color(UINT8 *color);
VIDEO_START( gmgalax )
{
VIDEO_START_CALL(galaxian);

modify_charcode = gmgalax_modify_charcode;
modify_spritecode = gmgalax_modify_spritecode;
modify_color = gmgalax_modify_color;
}

static void gmgalax_modify_charcode(UINT16 *code,UINT8 x)
{
*code |= (gfxbank[0] << 9);
}
static void gmgalax_modify_spritecode(UINT8 *spriteram,int *code,int *flipx,int *flipy,int offs)
{
*code |= (gfxbank[0] << 7) | 0x40;
}
static void gmgalax_modify_color(UINT8 *color)
{
*color |= (gfxbank[0] << 3);
}



to




void gmgalax_extend_tile_info(UINT16 *code, UINT8 *color, UINT8 attrib, UINT8 x)
{
*code |= gfxbank[0] << 9;
// *color |= gfxbank[0] << 3;
}

void gmgalax_extend_sprite_info(const UINT8 *base, UINT8 *sx, UINT8 *sy, UINT8 *flipx, UINT8 *flipy, UINT16 *code, UINT8 *color)
{
*code |= (gfxbank[0] << 7) | 0x40;
*color |= gfxbank[0] << 3;
}


*FIX*
----------------------------------------------------------------------------------
If you changed in src\mame\video\galaian.c (MAME 0.136u2) line 1276 from

// *color |= gfxbank[0] << 3;

to

        *color |= gfxbank[0] << 3;


you got all gfx in gmgalax back!
Github Commit
Flags
Regression Version 0.124u1
Affected Sets / Systems gmgalax
Attached Files
png file icon gmgalax-0124-0136u2.png (4,881 bytes) Feb 13, 2010, 00:20
jpg file icon DSCN1975.JPG (290,573 bytes) Jan 7, 2022, 16:44 Uploaded by Osso
PCB reference 1
Osso
jpg file icon DSCN1973.JPG (322,977 bytes) Jan 7, 2022, 16:45 Uploaded by Osso
PCB reference 2
Osso
Relationships
There are no relationship linked to this issue.
Notes
3
User avatar
No.05710
Haze
Senior Tester
Feb 13, 2010, 01:54
which begs the question, why was it commented out in the first place.

usually lines aren't commented out unless the person working on the driver thought theret was a good reason to do it, do you have any idea why it might have been done?
User avatar
No.19656
Osso
Developer
Jan 7, 2022, 16:42
Right now in the emulation the Galaxian game is using the same PROM of the Ghostmuncher game, instead of using its PROM.
Attached some screenshots from Guru that show that the pre 0.124u1 behaviour was right.
User avatar
No.20134
Robbbert
Developer
Apr 30, 2022, 11:18
Appears that during the creation of galaxold, this code was commented out probably for testing, and then forgotten about.