04127: Doesn't build for KFreeBSD

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
04127	Compiling	Minor	Always	Dec 8, 2010, 12:10	Dec 8, 2010, 16:38

Tester	Christian MArillat	View Status	Public	Platform	SDLMAME
Assigned To		Resolution	Suspended	OS	Other
Status [?]	Closed			Driver
Version	0.140u1	Fixed in Version		Build	Other
		Fixed in Git Commit		Github Pull Request #

Summary	04127: Doesn't build for KFreeBSD
Description	An include for pty.h is missing in src/osd/sdl/sdlptty_unix.c for KFreeBSD in 0.140u2. The following patch fix this issue : --- mame-0.140u2.orig/src/osd/sdl/sdlprefix.h 2010-12-08 11:42:34.000000000 +0100 +++ mame-0.140u2/src/osd/sdl/sdlprefix.h 2010-12-08 11:43:26.000000000 +0100 @@ -42,7 +42,7 @@ /* Large file support on IRIX needs _SGI_SOURCE */ #undef _POSIX_SOURCE -#elif defined(__linux__) +#elif defined(__linux__) \|\| defined(__FreeBSD_kernel__) #define SDLMAME_LINUX 1 #elif defined(__FreeBSD__)
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version
Affected Sets / Systems

Attached Files

No.06892 Tafoid Administrator Dec 8, 2010, 15:18	Acknowledged until R. Belmont can comment or address this.
No.06894 NekoEd Senior Tester Dec 8, 2010, 15:45	It also fails to build on Solaris as it looks for the string "solaris" in the uname output when it should be looking for "sunos" instead ("SunOS" is the kernel, the entire system, kernel included, is "Solaris".)
No.06895 Tafoid Administrator Dec 8, 2010, 16:38	I was asked that we take any SDL related build issues to the official SDLMAME forum rather than here. The link for this is: http://www.bannister.org/forums/ubbthreads.php?ubb=postlist&Board=8 Closing.