04789: avspirit, monkelf: Missing sprites

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
04789	Graphics	Major	Always	Apr 29, 2012, 19:32	May 16, 2012, 19:35

Tester	moa	View Status	Public	Platform	MAME (Unofficial Binary)
Assigned To	hap	Resolution	Fixed	OS	Windows Vista/7 (64-bit)
Status [?]	Resolved			Driver	jaleco/megasys1.cpp
Version	0.145u7	Fixed in Version	0.146	Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	04789: avspirit, monkelf: Missing sprites
Description	avspirit is missing sprites. monkelf has preexisting graphic issues as well unrelated to this. .
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version	0.145u7
Affected Sets / Systems	avspirit, monkelf

Attached Files

No.08476 Tafoid Administrator Apr 29, 2012, 20:23	There was a kludge needed for avsprit commented in the recent AM_BASE/AM_SHARE conversions: /* kludge: avspirit has 0x10000 bytes of RAM while edf has 0x20000. The / / following is needed to make vh_start() pick the correct address / / for spriteram16. */ //TODO:FIX //state->m_ram += 0x10000/2;
No.08495 Mamesick Senior Tester May 4, 2012, 19:45	This can be fixed with a small hack in VIDEO_START(megasys1): state->m_spriteram = &state->m_ram[0x8000/2]; if (strcmp(machine.system().name, "avspirit") == 0 \|\| strcmp(machine.system().name, "phantasm") == 0 \|\| strcmp(machine.system().name, "monkelf") == 0) state->m_spriteram = &state->m_ram[0x18000/2]; Sincerely I have no idea how to fix in a "clean" way without rewriting partially the driver (I mean: add a specific VIDEO_START and specific MACHINE_CONFIGURE for these games)

No.08476

Tafoid

Administrator

Apr 29, 2012, 20:23

There was a kludge needed for avsprit commented in the recent AM_BASE/AM_SHARE conversions:

/* kludge: avspirit has 0x10000 bytes of RAM while edf has 0x20000. The */
/* following is needed to make vh_start() pick the correct address */
/* for spriteram16. */
//TODO:FIX
//state->m_ram += 0x10000/2;

No.08495

Mamesick

Senior Tester

May 4, 2012, 19:45

This can be fixed with a small hack in VIDEO_START(megasys1):

	state->m_spriteram = &state->m_ram[0x8000/2];

	if (strcmp(machine.system().name, "avspirit") == 0 ||
		strcmp(machine.system().name, "phantasm") == 0 ||
		strcmp(machine.system().name, "monkelf") == 0)
		state->m_spriteram = &state->m_ram[0x18000/2];

Sincerely I have no idea how to fix in a "clean" way without rewriting partially the driver (I mean: add a specific VIDEO_START and specific MACHINE_CONFIGURE for these games)