05422: All sets in deco32.c, All sets in deco156.c: Volume is not working in service mode

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
05422	Sound	Minor	Always	Jan 10, 2014, 20:56	1 day ago

Tester	scoobydude51	View Status	Public	Platform	MAME (Official Binary)
Assigned To	Duke	Resolution	Fixed	OS	Windows Vista/7/8 (64-bit)
Status [?]	Resolved			Driver	dataeast/deco32.cpp
Version	0.152	Fixed in Version	0.285GIT	Build	Normal
		Fixed in Git Commit	54e52b1	Github Pull Request #

Summary	05422: All sets in deco32.c, All sets in deco156.c: Volume is not working in service mode
Description	Volume is not working in service mode. it is blaring at the maximum level even though I set it to "00".
Steps To Reproduce
Additional Information	I also set the option "Loudness" at "Off", but that didn't work.
Github Commit

Flags
Regression Version
Affected Sets / Systems	All sets in deco32.c, All sets in deco156.c

Attached Files	service_mode_with_vol_at_00.png (2,213 bytes) Jan 10, 2014, 20:56 Uploaded by scoobydude51 Service Mode with Volume at "00"

No.10162 Tafoid Administrator Jan 10, 2014, 21:01	While there is not an explicit note in the driver, there is a area which is believed to be the internal volume control which is NOP'd out: AM_RANGE(0x0410000, 0x0410003) AM_WRITENOP /* Some kind of serial bit-stream - digital volume control? */ I would assume this would give the 0 value regardless of what it is changed to.
No.10163 scoobydude51 Tester Jan 10, 2014, 21:27 edited on: Jan 10, 2014, 21:28	that explains everything. I changed the affected sets to "All Sets in deco32.c" because it seems like this code you mentioned is affecting all of the sets.
No.10172 scoobydude51 Tester Jan 12, 2014, 00:16 edited on: Jan 12, 2014, 00:19	EDIT: I discovered that the sets in deco156.c has this bug too. don't know why...
No.23979 JimCarlTay Tester 1 day ago	deco32: Tried with dragngun (the screenshot depicts this game's sound test menu), I am not able to reproduce. So likely fixed as of build 32c05f4, but I do not know what commit fixed this. deco156: Tried with hvysmsh. The issue still happens here.
No.23980 JimCarlTay Tester 1 day ago	Other games: (parent sets only) deco32 (excluding captaven and tattass): Like with dragngun, fghthist now has a working volume adjustment in the sound test menu. The issue still happens in lockload. captaven, however, only uses DIP switches, not a service menu. deco156: wcvol95 does not have a sound test menu.
No.23983 Duke Developer 1 day ago	Initial volume control support for dragngun was added in commit c7d1aeb956c3d25ca8f30ab6b27f33ce4e599f25. Commit 54e52b1d5aa267f4b8581a1b86a10fda5335c33b fixes volume control for lockload and implements volume control support for hvysmsh. Note: Loudness isn't emulated yet by the lc7535 device.
No.23988 JimCarlTay Tester 1 day ago	Unfortunately, the loudness setting still doesn't work (tested with dragngun).
No.23989 JimCarlTay Tester 1 day ago	Never mind my previous note.