00650: saturn.c games: P1 and P2 Button 4 are duplicated.

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
00650	DIP/Input	Trivial	Have not tried	Feb 1, 2008, 05:28	Aug 24, 2008, 04:21

Tester	-Misc Reporters-	View Status	Public	Platform
Assigned To		Resolution	Fixed	OS
Status [?]	Resolved			Driver	sega/saturn.cpp
Version	0.118u2	Fixed in Version	0.127u1	Build
		Fixed in Git Commit		Github Pull Request #

Summary	00650: saturn.c games: P1 and P2 Button 4 are duplicated.
Description	P1 and P2 Button 4 are duplicated.
Steps To Reproduce
Additional Information	Posted by kosodate_chan stv.c merged into saturn.c in 0.142u2
Github Commit

Flags
Regression Version
Affected Sets / Systems	saturn.c games

Attached Files

No.01081 couriersud Developer May 24, 2008, 21:35	This is caused by /Extra button layout,used by Power Instinct 3 & Suikoenbu/ PORT_START PORT_BIT( 0x01, IP_ACTIVE_LOW, IPT_BUTTON4 ) PORT_PLAYER(1) PORT_BIT( 0x02, IP_ACTIVE_LOW, IPT_BUTTON5 ) PORT_PLAYER(1) ... Not sure however, if this should be move into a separate input port definition ...
No.02198 etabeta Developer Aug 24, 2008, 04:21 edited on: Aug 24, 2008, 04:22	After testing all the sets which reach the Test Mode, I concluded that only batmanfr was using the P1 Button 4 from the input port tagged as "P1" (& "P2"). All other games using a 4th button (currently astrass, elandore, gaxduel, groovef and suikoenb) uses the one from the "EXTRA" input port. Therefore, I made the "P1" (& "P2") button 4 a batmanfr specific input, removing the duplicate input. Fix sent to MAMEdev, it should be in 0.127u1.

No.01081

couriersud

Developer

May 24, 2008, 21:35

This is caused by

/*Extra button layout,used by Power Instinct 3 & Suikoenbu*/
PORT_START
PORT_BIT( 0x01, IP_ACTIVE_LOW, IPT_BUTTON4 ) PORT_PLAYER(1)
PORT_BIT( 0x02, IP_ACTIVE_LOW, IPT_BUTTON5 ) PORT_PLAYER(1)
...

Not sure however, if this should be move into a separate input port definition ...

No.02198

etabeta

Developer

Aug 24, 2008, 04:21

edited on: Aug 24, 2008, 04:22

After testing all the sets which reach the Test Mode, I concluded that only batmanfr was using the P1 Button 4 from the input port tagged as "P1" (& "P2"). All other games using a 4th button (currently astrass, elandore, gaxduel, groovef and suikoenb) uses the one from the "EXTRA" input port.

Therefore, I made the "P1" (& "P2") button 4 a batmanfr specific input, removing the duplicate input. Fix sent to MAMEdev, it should be in 0.127u1.