06637: Internal UI does not save entire configuration

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
06637	Interface	Major	Always	Jul 30, 2017, 18:56	Oct 31, 2017, 00:15

Tester	Iaspis	View Status	Public	Platform	MAME (Official Binary)
Assigned To	AJR	Resolution	Fixed	OS	Windows 10 (64-bit)
Status [?]	Resolved			Driver
Version	0.188	Fixed in Version	0.191	Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	06637: Internal UI does not save entire configuration
Description	mame.ini is missing all options from OSD KEYBOARD MAPPING OPTIONS and below (compared to 0.187 mame.ini). As a result, respective option changes in the ui are not applied and saved after restarting MAME.
Steps To Reproduce	Go to video options, change Wait Vertical Sync to ON and save configuration. Restart MAME and notice that it is set to OFF again.
Additional Information	Regression during Options Overhaul commit on June 24, 2017 https://github.com/mamedev/mame/commit/b193e05cd7c8456a2648d43854645da84f56ddbd
Github Commit

Flags
Regression Version	0.188
Affected Sets / Systems

Attached Files

No.14034 Tafoid Administrator Jul 30, 2017, 20:27	Are you saying new mame.ini created with "mame -cc" does have anything listed for OSD KEYBOARD MAPPING OPTIONS and beyond?
No.14035 Tafoid Administrator Jul 30, 2017, 23:31	I can confirm starting MAME -> Pick Game -> Configure Machine -> Save machine configuration The output file is about half of what it should be and stops at the Title mentioned before outputting: "OSD KEYBOARD MAPPING OPTIONS" Using mame -cc outputs everything to mame.ini. -showusage and -showconfig both also output the entire configuration.
No.14036 Tafoid Administrator Jul 30, 2017, 23:45	Fix for this is in GitHub as a Pull Request: https://github.com/mamedev/mame/pull/2530
No.14049 cuavas Administrator Aug 1, 2017, 17:47	That PR is a horrible hack. The code in MAME proper shouldn't ever need to know specifics of the OSD implementation.
No.14227 Tafoid Administrator Oct 7, 2017, 00:54	Nathan Wood with AJR assist here: https://github.com/mamedev/mame/commit/04722f2fcf8c21bc5ddc58a5acd9838dbfe21084
No.14338 wuemura Viewer Oct 28, 2017, 23:29 edited on: Oct 28, 2017, 23:34	This issue still not fixed in 191 and 191GIT, the bug still remains. Steps to reproduce. 1. Delete mame.ini 2. mame -createconfig 3. Run mame, go to Configure Options > Save Configuration 4. this lines are missing from the mame.ini after saving it. --- mame-original.ini 2017-10-28 21:18:31.178246500 -0200 +++ mame.ini 2017-10-28 21:19:22.265970800 -0200 @@ -448,8 +448,3 @@ # global_inputs 0 dual_lightgun 0 - -# -# FRONTEND COMMAND OPTIONS -# -dtd 1
No.14374 wuemura Viewer Oct 30, 2017, 22:10	Could some admin or developer acknowledge this? Thank you.
No.14375 Robbbert Senior Tester Oct 31, 2017, 00:15	You have raised a new issue that has nothing to do with the original problem. Please raise a new bug report.