06654: c64: In some cases, changing slots and choosing RESET crashes MAME

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
06654	Interface	Critical (emulator)	Always	Aug 11, 2017, 23:40	Jul 20, 2019, 12:32

Tester	Robbbert	View Status	Public	Platform	MAME (Official Binary)
Assigned To	AmatCoder	Resolution	Fixed	OS	Windows Vista/7/8 (64-bit)
Status [?]	Resolved			Driver	commodore/c64.cpp
Version	0.188	Fixed in Version	0.212	Build
		Fixed in Git Commit		Github Pull Request #

Summary	06654: c64: In some cases, changing slots and choosing RESET crashes MAME
Description	----------------------------------------------------- Exception at EIP=00000000031c28a7 (emu_options::image_option(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)+0x0077): ACCESS VIOLATION While attempting to read memory at 0000000000000028 ----------------------------------------------------- RAX=0000000000000000 RBX=00000000174a2930 RCX=b5e970bff2c55b7e RDX=0000000000000008 RSI=000000000000000b RDI=029b0cea6da7c6b5 RBP=0000000000227f50 RSP=0000000000227ed0 R8=0000000000000536 R9=c6a4a7935bd1e995 R10=7bcf33d89bc8ed5e R11=000000000d902480 R12=0000000000000008 R13=000000000d902468 R14=000000000d8d7750 R15=fffffffffffffffe ----------------------------------------------------- Stack crawl: 0000000000227ea0: 00000000031c28a7 (emu_options::image_option(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)+0x0077) 0000000000228270: 00000000031d5189 (image_manager::options_extract()+0x0679) 00000000002282d0: 00000000031d5563 (image_manager::unload_all()+0x0033) 0000000000228310: 00000000031f8c69 (running_machine::call_notifiers(machine_notification)+0x0049) 0000000000228410: 00000000031ff6ba (running_machine::run(bool)+0x04ba) 000000000022f1d0: 0000000001bf5af3 (mame_machine_manager::execute()+0x01e3) 000000000022f490: 0000000001c502a6 (cli_frontend::start_execution(mame_machine_manager*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&)+0x0416) 000000000022f600: 0000000001c50755 (cli_frontend::execute(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)+0x0045) 000000000022f660: 0000000001bf3c3a (emulator_info::start_frontend(emu_options&, osd_interface&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)+0x002a) 000000000022fdb0: 0000000001b47452 (utf8_main(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)+0x0122) 000000000022fe50: 0000000003771b49 (wmain+0x0169) 000000000022ff20: 0000000000401410 (__tmainCRTStartup+0x0260) 000000000022ff50: 000000000040153b (mainCRTStartup+0x001b) 000000000022ff80: 00000000770659cd (BaseThreadInitThunk+0x000d) 000000000022ffd0: 000000007719a561 (RtlUserThreadStart+0x0021)
Steps To Reproduce	mame c64 -iec11 c1526 Get UI control, TAB, Slot Options and select that slot to read "fd4000". Choose RESET
Additional Information	Regression: June 24, 2017 https://github.com/mamedev/mame/commit/b193e05cd7c8456a2648d43854645da84f56ddbd
Github Commit

Flags
Regression Version	0.188
Affected Sets / Systems	c64

Attached Files

No.14099 Tafoid Administrator Aug 17, 2017, 02:45	PR#2555 addresses this, but is uncommitted as of now. https://github.com/mamedev/mame/pull/2555
No.16678 Robbbert Senior Tester Jul 20, 2019, 12:32	https://github.com/mamedev/mame/commit/a14ec2ca5c5613e032159ee1c854a99e19a8e7d7