06775: coco, coco2, dragon and clones: Software list does not work for floppy devices

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
06775	Media Support	Feature	Always	Nov 26, 2017, 20:57	Apr 13, 2018, 18:53

Tester	MrGW	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	Pernod	Resolution	Fixed	OS	Linux (64-bit)
Status [?]	Resolved			Driver	trs/coco12.cpp
Version	0.191	Fixed in Version	0.197	Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	06775: coco, coco2, dragon and clones: Software list does not work for floppy devices
Description	I am unable to see/select floppy disk based software using MAME's software list function in the UI for the coco2 driver. I edited the coco_flop.xml in the hash folder and added the following entry: <!-- coco2 only - coco2 driver) --> <!-- RUN"ASM-DEMO.BIN" --> <software name="asmdemo" supported ="partial"> <description>Tandy Assembly Demo 2017</description> <year>2017</year> <publisher>Simon Jonassen</publisher> <sharedfeat name="compatibility" value="COCO2" /> <info name="author" value="Simon Jonassen" /> <part name="flop0" interface="floppy_5_25"> <dataarea name="flop" size="161280"> <rom name="asmdemo.dsk" size="161280" crc="6e2533f7" sha1="ebf6edfc4df71c0c450d4a72bac45f1308cf66ba" offset="0" /> </dataarea> </part> </software> If I change that entry slightly by changing the "compatibility" entry value to "COCO3", I can successfully see it and select it when using a coco3 driver. It seems MAME only allows for software list selection when using the coco3 driver and not the coco2 driver.
Steps To Reproduce	Load/run MAME using the coco2 driver: mame coco2 Bring up MAME's UI Select File Manager Select FloppyDisk1 (flop1) Select Software List No entries will show up.
Additional Information	I've attached a copy of the coco_flop.xml file I edited and also Simon's Tandy Assembly 2017 DSK image.
Github Commit

Flags
Regression Version
Affected Sets / Systems	coco, coco2, dragon and clones

Attached Files	asmdemo.zip (9,484 bytes) Nov 26, 2017, 20:57 Uploaded by MrGW

No.14467 Tafoid Administrator Nov 26, 2017, 23:58	It loads find via picker: mame coco2 -flop1 asmdemo.zip and when I mount it and then: LOADM"ASM-DEMO.bin", EXEC it seems to run fine. You are assuming a compatibility option which has not been detailed in source. In fact, coco12.cpp doesn't even have a software list attached in the driver for floppies, just carts (for coco and dragon), so there is no wonder no entries show up. coco12.cpp // software lists MCFG_SOFTWARE_LIST_ADD("coco_cart_list", "coco_cart") MCFG_SOFTWARE_LIST_FILTER("coco_cart_list", "COCO") MCFG_SOFTWARE_LIST_COMPATIBLE_ADD("dragon_cart_list", "dragon_cart") coco3.cpp // software lists MCFG_SOFTWARE_LIST_ADD("cart_list","coco_cart") MCFG_SOFTWARE_LIST_FILTER("cart_list","COCO3") MCFG_SOFTWARE_LIST_ADD("flop_list","coco_flop") MCFG_SOFTWARE_LIST_FILTER("flop_list","COCO3") This bug report is essentially a feature request. If you are willing to make such a list, it should be easy to add. There is an argument that coco_flop should be renamed coco3_flop (and handle only coco3 titles) only when coco_flop can be utilized for normal commercially produced disk images/known to work on original hardware images.
No.14468 MrGW Tester Nov 27, 2017, 01:24	Hi Tafoid, I had no idea this was a 'coco3' only driver option. I am willing to create a proper software list XML file for the 'coco12' driver and supply the correct DSK image files for it. It will initially be a small collection of games and utilities. Once support for this has been added to the 'coco12' driver, I'm guessing this list can be expanded on over time. Separate XML files for the 'coco3' and 'coco12' drivers would be fine or the continued use of the single 'coco_flop' file with the ability to assign a specific coco driver to corresponding compatible files if required. Is there a proper process to use for requesting this feature be added for the 'coco12' driver? Thanks for all your help!
No.14482 MrGW Tester Nov 29, 2017, 22:33	Hi Tafoid. I have a working script to generate a floppy disk software list file (XML) based on the current specs MAME requires. I've tested it by processing DSK images from the TRS-80 Color Computer Archive. As you've mentioned, MAME only supports the floppy disk software lists for the Coco 3. How can I officially request support be added for the Coco 1 and 2? Thanks!
No.14483 Tafoid Administrator Nov 30, 2017, 00:12	Like with all requests, it would take someone with interest in it to work out adding support, using your reference software list of titles which are confirmed good and working and run on original hardware. This bug report is as official as anything. Please remember, this is volunteer work and an open source project that is sustained by external contributions of code and information. Sadly, this driver (among most others) doe not have an GO TO Developer who will work on it frequently.