07316: vgmplay: crashes when sliders selected

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07316	Crash/Freeze	Critical (emulator)	Always	May 4, 2019, 06:47	May 9, 2019, 04:18

Tester	Robbbert	View Status	Public	Platform	MAME (Self-compiled)
Assigned To	jkm900	Resolution	Fixed	OS	Windows Vista/7/8 (64-bit)
Status [?]	Resolved			Driver	virtual/vgmplay.cpp
Version	0.209	Fixed in Version	0.210	Build	32-bit
		Fixed in Git Commit		Github Pull Request #

Summary	07316: vgmplay: crashes when sliders selected
Description	crashes when sliders selected
Steps To Reproduce	Start vgmplay. Press Tab Select Slider Controls Crash.
Additional Information
Github Commit

Flags
Regression Version	0.209
Affected Sets / Systems	vgmplay

Attached Files

No.16420 Tafoid Administrator May 4, 2019, 12:11	Exception at EIP=00000000051f7aff (ioport_field::get_user_settings(ioport_field::user_settings&)+0x003f): ACCESS VIOLATION While attempting to read memory at 0000000000000110 ----------------------------------------------------- Stack crawl: 0000000000228ab0: 00000000051f7aff (ioport_field::get_user_settings(ioport_field::user_settings&)+0x003f) 0000000000228e80: 000000000384339d (mame_ui_manager::slider_changed(running_machine&, void, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int) [clone .part.391]+0x025d) 0000000000228f10: 00000000038444c0 (mame_ui_manager::slider_changed(running_machine&, void, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int)+0x0030) 0000000000228f60: 0000000007d60596 (std::_Function_handler<int (running_machine&, void, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int), std::_Bind<int (mame_ui_manager::(mame_ui_manager, std::_Placeholder<1>, std::_Placeholder<2>, std::_Placeholder<3>, std::_Placeholder<4>, std::_Placeholder<5>))(running_machine&, void, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int)> >::_M_invoke(std::_Any_data const&, running_machine&, void&&, int&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, int&&)+0x0046) 00000000002291a0: 0000000003954527 (ui::menu_sliders::populate(float&, float&)+0x03e7) 0000000000229210: 0000000003946285 (ui::menu::ui_handler(render_container&, mame_ui_manager&)+0x0135) 0000000000229240: 0000000007d60dc7 (std::_Function_handler<unsigned int (render_container&), std::_Bind<unsigned int (*(std::_Placeholder<1>, std::reference_wrapper<mame_ui_manager>))(render_container&, mame_ui_manager&)> >::_M_invoke(std::_Any_data const&, render_container&)+0x0017) 0000000000229340: 000000000384177b (mame_ui_manager::update_and_render(render_container&)+0x016b)
No.16422 Tafoid Administrator May 4, 2019, 12:42 edited on: May 4, 2019, 12:42	https://github.com/mamedev/mame/commit/99cc29b2c9742f8b790330fa94cbe1f2cb3137e5 This appears to be the breaking commit - March 31, 2019
No.16427 Robbbert Senior Tester May 5, 2019, 00:46	Removal of that commit does not change anything - it still crashes.
No.16428 Tafoid Administrator May 5, 2019, 01:55	It isn't crashing on a specific sound entry, but a generic UI entry attempting to populate the list. The day prior a slider count from top to bottom was 255 entries. Coincidence? Not sure.
No.16429 Robbbert Senior Tester May 5, 2019, 07:00	Yeah, seems vgmplay is 4 sliders over the limit currently.
No.16440 jkm900 Tester May 8, 2019, 10:38 edited on: May 8, 2019, 10:39	Fixed in https://github.com/mamedev/mame/pull/5009 . Additional info: This fixes volume, too.
No.16441 Robbbert Senior Tester May 9, 2019, 04:18	Fixed by cam900.