07830: Lua Cheat Plugin: Cheats show errors attempting to activate

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
07830	Plugins	Major	Always	Dec 31, 2020, 09:34	Jan 10, 2021, 02:41

Tester	-Misc Reporters-	View Status	Public	Platform	MAME (Official Binary)
Assigned To	crazyc	Resolution	Fixed	OS	Windows Vista/7/8 (64-bit)
Status [?]	Resolved			Driver
Version	0.227	Fixed in Version	0.228	Build
		Fixed in Git Commit		Github Pull Request #

Summary	07830: Lua Cheat Plugin: Cheats show errors attempting to activate
Description	While loading/populating cheats via Lua cheat plugin seems to work ok, once you attempt to activate you are presented with errors. Use of -cheat (debugger) based internal cheat engine seems to still work fine.
Steps To Reproduce	In the pictured example > mame64 vf -plugins -plugin cheat When you activate the 2 top most cheats, the output to console shows: error cheat script error: "Infinite Credits" [string "Infinite Creditsrun"]:1: attempt to call a nil value (method 'write_log_u8') error cheat script error: "Infinite Time (Incomplete)" [string "Infinite Time (Incomplete)run"]:1: attempt to call a nil value (method 'write_log_u16')
Additional Information	Taken from report here https://www.reddit.com/r/MAME/comments/knlfs0/mame_0227/ghl6jes/
Github Commit

Flags
Regression Version	0.227
Affected Sets / Systems	Lua Cheat Plugin

Attached Files	58EcfvH.jpg (650,117 bytes) Dec 31, 2020, 09:36 Uploaded by Tafoid vf attempted use of cheats via Lua plugin

No.18311 AJR Developer Jan 1, 2021, 04:11	This was probably broken by commit 503332a9867f9aa27fc77cd9e762626d22d213ef, which renamed write_log_* to writev_*. Since these Lua functions do not appear to be used in plugin files maintained as part of the MAME project (though one reference in a C++ comment was overlooked), it appears that external cheat scripts need to be updated in accordance with this.
No.18359 crazyc Developer Jan 10, 2021, 00:57	This was fixed by https://github.com/mamedev/mame/commit/525f744b38f03e672eaac4d9fd7946c08b5e2221#diff-cfd2b4342265008a57562492c878a3beef58febda9c87e2b47404bd3f5c2b7e7 .