Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
07930 Sound Minor Always 18 days ago 21 hours ago
Tester Emuissues View Status Public Platform MAME (Official Binary)
Assigned To aaron Resolution Fixed OS Windows 10 (64-bit)
Status [?] Resolved Driver segas16b.cpp
Version 0.230 Fixed in Version 0.231GIT Build 64-bit
Fixed in Git Commit 782d827 Github Pull Request #
Summary 07930: shinobi2: Missing Instrument and bad helicopter sound.
Description The sound driver of Shinobi for System 16B (shinobi2 rom) is not accurate. The cymbals sound of the drum set are not playing correctly and the helicopter sound on Mission 2 is "corrupted".
Steps To Reproduce
Additional Information You can see this video for a comparison:
Github Commit
Flags
Regression Version
Affected Sets / Systems shinobi2
Attached Files
? file icon shinobi2.inp (117,443 bytes) 17 days ago Uploaded by Emuissues
Relationships
There are no relationship linked to this issue.
Notes
21
User avatar
No.18650
aaron
Developer
17 days ago
Thank you for the report. Are you able to test with the latest from github? I have made a few fixes that might help at least the helicopter sound. Or do you have an INP that plays through to get to the helicopter part?
User avatar
No.18651
Tafoid
Administrator
17 days ago
The helicopter sound can also be accessed by using the Service Mode Sound Test .. Entry 1E
To me, that does sound corrected in current Git, but I'm far from an audio expert. It surely beats 0.230's presentation.
User avatar
No.18652
Emuissues
Tester
17 days ago
Yes, in the current Git it's fixed. Very thank you. I've uploaded the .inp btw.
Is there any possibility to fix cymabls sound to match the pcb?
User avatar
No.18656
aaron
Developer
16 days ago
Thanks for confirming the helicopter. Haze mentioned the cymbals could be due to the netlist filtering. Are you running the System 16A shinobi set or one of the System 16B versions?

16A versions = shinobi, shinobi1, shinobls, shinoblb
16B versions = shinobi2, shinobi2d, shinobi3, shinobi4, shinobi5, shinobi6

I wonder how the sound differs between the two versions. Only the 16B has netlist filtering, so if you run one of the 16A sets it won't have the filtering.
User avatar
No.18657
vidpro1
Developer
16 days ago
I can confirm on MAME 230 Waiting helicopter sounded funny after all hostages freed. I'll try the fixed one.
User avatar
No.18658
Emuissues
Tester
16 days ago
I'm running System 16B, shinobi2 set.
User avatar
No.18661
Augusto
Tester
15 days ago
edited on: 15 days ago
how for test disable netlist filtering ?
I have noticed even in Windows and Linux that using portudio if using CPU Power Profile PowerSave even having enough CPU time for emulation happen the problem that is being said above with pops in sound for some games mainly "old" games using AY and YM sound chips and strangely when accessing OSD menu plugins happen very much pops in sound and if accessing others menus not problems in sound.
Several version before the option "resample if sample rate not match" was removed from mame user configuration and not removed from mame sound core, but internally enabled for good.
Perhaps anything related with "resamplefilter" ?
User avatar
No.18672
Emuissues
Tester
10 days ago
The cymbals issue happen in the 16A version too... I doubt it's caused by the filtering.
User avatar
No.18681
abelardator2
Tester
10 days ago
I add recording of music and sound effects from PCB capture.

MUSIC: https://drive.google.com/file/d/1qfCHLjNTmJC2wGyLnq4j_Zp-sCF5Bexp/view?usp=sharing

SOUND EFFECTS: https://drive.google.com/file/d/170VFaRo2m_NccMZrnwoMp3nyGUomG5YN/view?usp=sharing
User avatar
No.18682
Emuissues
Tester
10 days ago
You can notice the issue from minute 1:03 onwards of the video that I posted.
User avatar
No.18683
aaron
Developer
9 days ago
Can I access the music track from test mode? If so, which one is it?
User avatar
No.18684
aaron
Developer
9 days ago
abelardator2, thanks for the recordings. Are those during gameplay or from test mode?
User avatar
No.18685
Emuissues
Tester
9 days ago
edited on: 9 days ago
aaron, you can access to the music track list pressing F2, and when enter in service mode, press F2 again. From now on you can hit the attack button CTRL in mame by default to change the music tracks. The track nº5 is a good example of cymbals sound.
Thank you for looking into this.
User avatar
No.18687
abelardator2
Tester
9 days ago
Aaron, yes, I accessed the test mode in the PCB and played the sound consecutively.
User avatar
No.18714
StHiryu
Tester
4 days ago
Before delving further into this problem, I would test if cymbals are present in all emulated Shinobi sets (6 differents). It is not the first time that supposed bugs are actually features present in certain sets and absent in others.

For example, the climatic effects in the Turbo Out Run appear differently depending on the version of the board (07589).
User avatar
No.18715
Emuissues
Tester
4 days ago
All sets have this problem. I tested myself before doing the video.
User avatar
No.18727
aaron
Developer
1 day ago
edited on: 1 day ago
Ok, I think I have this fixed now. The envelope was programmed for instant attack, super fast decay, but with a sustain level of 0. We were allowing the decay to happen for one tick in this situation when it should have stuck at minimum attenuation. Now the cymbal sound has a bit of pitch, which it was missing before. Let me know if this sounds closer.
User avatar
No.18730
Emuissues
Tester
23 hours ago
Aaron, you are breathtaking, sir.
Yes, it is fixed now. I don't know if its 100% accurate but at least for me it totally is.
Now Shinobi in mame presents a better emulation than sega's astro city mini thanks to you.
Thank you endlessly.
User avatar
No.18731
aaron
Developer
23 hours ago
Thanks for confirming. Here is a comparison of the isolated sound: https://aarongiles.com/for/mame/shinobi-compare.wav
User avatar
No.18733
Emuissues
Tester
22 hours ago
Outstanding difference!! Thank you. Really.
User avatar
No.18734
enik2
Tester
22 hours ago
Aaron, when you have some time could you take a look at the aliasing sound problem of the SMS port?

https://mametesters.org/view.php?id=5830

Not FM related, but the problem persisted after the 0.225 sound sample rate conversion and mixing changes.