Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
07956 Sound Minor Always 18 days ago 7 days ago
Tester Alex7 View Status Public Platform MAME (Official Binary)
Assigned To Resolution Open OS Windows 10 (64-bit)
Status [?] Confirmed Driver neogeo.cpp
Version 0.230 Fixed in Version Build 64-bit
Fixed in Git Commit Github Pull Request #
Summary 07956: mslug, mslugx, garou: lower volume on parts of music
Description the music on any neogeo games have lower volume on some parts and some are higher
games i tested are mslugs series and garou mark of the wolves
maybe this have something to do with the recent updates on the sound ?

this is most notable on the train part of stage 8 music on metal slug x or 2

this videos are recorded from real hardware

mslugx


and metal slug 1 on stage 2 music
Steps To Reproduce just play the game and hear the music
Additional Information
Github Commit
Flags Verified with Original
Regression Version
Affected Sets / Systems mslug, mslugx, garou
Attached Files
zip file icon stage 2.zip (31,748 bytes) 18 days ago Uploaded by Alex7
save sates
zip file icon stage 8.zip (30,204 bytes) 18 days ago Uploaded by Alex7
metal slug x
Relationships
There are no relationship linked to this issue.
Notes
16
User avatar
No.18749
Haze
Senior Tester
18 days ago
is this report for 0.230 or 0.231?
User avatar
No.18750
Alex7
Tester
18 days ago
Well I've used this nightly build https://www.mediafire.com/file/yebelb1gu6kcavu/26042021-19.39_mame.7z/file so I guess it makes it 231 but that issues were found on 230 too
User avatar
No.18751
Robbbert
Developer
18 days ago
Things may have changed. Try downloading the official 0.231 from mamedev.org and see if the issue still exists with that.
User avatar
No.18755
Haze
Senior Tester
17 days ago
edited on: 17 days ago
a nightly from 26th should be the freeze code however.

that said, the differences are not obvious, I can't hear them, and Youtube links of complete playthroughs aren't great - ideally the wavs need extracting from the video around the exact area the differences exist and wav files from MAME, recorded with -wavwrite, stripped down to the same segments for direct comparison.

these things are only obvious if you're already intimately familiar with the songs, we're not.

(also verification from multiple sources would help, just in case it's an issue with the capture hardware of this one specific uploader)
User avatar
No.18756
Keade
Tester
17 days ago
edited on: 17 days ago
I cannot spot (by ear) any difference on MS stage 2 either, comparing 0.231, 0.230 and the provided video, they all sound virtually identical.
Haven't checked the other sample (stage 8).

EDIT: you are right, hap, I can confirm I noticed the volume thing you describe on Garou MOTW selection screen. I will be back shortly to upload MOTW samples as well as re-check mslug (and provide cut/normalized recordings) to confirm also
User avatar
No.18757
hap
Developer
17 days ago
edited on: 17 days ago
I think he means volume, and yeah I can clearly hear the difference. The lead instrument volume on mslug stage 2 is less audible on MAME 0.231.

*edit* if I can make a guess: the lead melody there is probably FM, and the bassline (and obviously the drums) sound like they're adpcm. FM volume may be too low in ym2610.
User avatar
No.18758
Alex7
Tester
17 days ago
i think exactly what hap is saying
User avatar
No.18759
Foxhack
Tester
17 days ago
edited on: 17 days ago
We talked about this on Discord, I can confirm that there is something weird going on with the audio levels in Garou. It's very noticeable in the character select screen - there's supposed to be a trumpet playing in the background, and it is noticeably quieter in the current MAME release.

Edit: Also VERY noticeable in the ending theme for Hotaru Futaba.
(At 6:15) Playing track 0x072B in a music player (like the Universe Bios) will let you hear exactly what the issue is.
User avatar
No.18760
Keade
Tester
17 days ago
edited on: 13 days ago
I have uploaded mslug and garou recordings there: https://mega.nz/file/rXhCFBIC#YgRnzwNWMuT2LmIBMcxFa7WM6s5LBbjq5sRPDEyi2wY if that can help.
In the archive are included wavwrite for 0.229, 0.230, 0.231 as well as the audio for the reference videos I could find (the mslug stage 2 video mentionned in this bug report page, and for MOTW, recordings I found on Youtube - the filename is the video id: ttps://www.youtube.com/watch?v=<filename> is the video link, the links are ttps://www.youtube.com/watch?v=NXmOrPxIMG8 and ttps://www.youtube.com/watch?v=Qk6lnuQu80A. I have removed the https to avoid automatic embed).
All samples cut and normalized (with Audacity, I didn't change DC offset) to make it easier to compare.
I can confirm I can hear the issue on mslug stage 2 as well (it is easier to spot at the very beginning of the stage music).

EDIT: edited DL link (sorry it was broken)
EDIT2: to Alex7, you have to remove the trailing comma from the hyperlink (it's not part of it), upon opening the page you have to accept their cookie policy and whatever before you can actually DL, it should work after that.
EDIT3: replaced wetransfer link with Mega link (because wetransfer link would expire quickly), also removed trailing comma to avoid hyperlink issues
User avatar
No.18761
Alex7
Tester
17 days ago
it does not let me download could you upload to somewhere elese like google drive or mega?

also i was testing new MAME 231 issues are still present i tested the entire neo geo driver this time i can confirm driver is affected
some are very noticeable some are more difficult to spot
User avatar
No.18779
Mamesick
Senior Tester
16 days ago
Other good examples where to hear the differences are Blazing Star intro music and Pulstar intro music. I would say that all games in the driver are affected, so the title of the bug should be updated.
User avatar
No.18780
Alex7
Tester
15 days ago
yeah i just said mslug mslug x and garou for refeference but all games on neogeo system are affected
User avatar
No.18790
Mamesick
Senior Tester
13 days ago
Looks like the portions of music with lower volume are played by the ADPCM-B channel, not the FM one. In particular, this line in DEVICES/SOUND/YM2610.CPP is the cause of the issue (line 287)
	m_adpcm_b.output(sums, 2, 0x01);
According to source code, that "2" value is used in a function to reduce/normalize the output volume. The value 2 is too much and causes the issues. To have things like they were before, simply change:
	m_adpcm_b.output(sums, 1, 0x01)
I wonder if the same fix should be done for YM2608.CPP since it's pretty identical... but for the moment nobody reported issue with this chip, only for YM2610.
User avatar
No.18793
Steve Coomber
Tester
13 days ago
There are not many games on MAME using the YM2608 which is probably why it hasn't been reported. I just tried out Mechanized Attack and noticed a difference in audio levels when comparing the latest MAME release to an earlier release (in my case MAME v0.223) so it could be affected by the same issue.
User avatar
No.18795
Haze
Senior Tester
13 days ago
I specifically adjusted mechatt based on the new code, so different levels are expected, however, if the levels change in the core again, they'll have be readjusted in the driver once more.
User avatar
No.18822
danylopez123
Tester
7 days ago
I've started to noticed that change of the instrument volumes with some Neo Geo games and then i realized that this got affected on any Neo Geo Game.
I am not sure if again, thanks to the YM chips change, other games that uses the YM sound chips also got the instrument volumes different.