08081: srmp2, srmp3: No Character voices

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
08081	Sound	Minor	Always	Sep 11, 2021, 00:28	Sep 11, 2021, 18:22

Tester	MARBIN	View Status	Public	Platform	MAME (Official Binary)
Assigned To	kmg	Resolution	Fixed	OS	Windows 10 (64-bit)
Status [?]	Resolved			Driver	seta/srmp2.cpp
Version	0.235	Fixed in Version	0.236	Build	64-bit
		Fixed in Git Commit	6d51055	Github Pull Request #

Summary	08081: srmp2, srmp3: No Character voices
Description	Character voices are not played on srmp2 and srmp3. I confirmed this bug on mame 0.235. Also, I confirmed that this bug does not exist on mame 0.226.
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version	0.227
Affected Sets / Systems	srmp2, srmp3

Attached Files

No.19239 Tafoid Administrator Sep 11, 2021, 02:51	Tracking this suggests this is the commit to look at, traced to my daily binaries as October 31, 2020 - although I'm not sure why: https://github.com/mamedev/mame/commit/aa4451f31ddcd0175ef0a56afee3b9126832659d
No.19240 kmg Senior Tester Sep 11, 2021, 03:22 edited on: Sep 11, 2021, 03:23	There looks to be a type conversion error issue introduced by making m_adpcm_data uint8_t, though there may be other problems. At a glance it looks like the code is using -1 as a sentinel and this line is always false for instance: https://github.com/mamedev/mame/blob/668f3fd816e78dbab8affae8c645424288c55ee2/src/mame/drivers/srmp2.cpp#L233
No.19241 Osso Moderator Sep 11, 2021, 18:22	Yes, my bad, sorry.