08137: UI: Selecting "Favorites" system filter without having any entries causes segmentation fault

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
08137	Interface	Critical (emulator)	Always	Nov 22, 2021, 23:12	Nov 23, 2021, 00:57

Tester	Tafoid	View Status	Public	Platform
Assigned To	cuavas	Resolution	Fixed	OS
Status [?]	Resolved			Driver
Version	0.237	Fixed in Version	0.238	Build
		Fixed in Git Commit	5668590	Github Pull Request #

Summary	08137: UI: Selecting "Favorites" system filter without having any entries causes segmentation fault
Description	Selecting "Favorites" within UI without having any entries causes exception. If you have 1 or more entries, the Favorites selection appears to look and work correctly.
Steps To Reproduce
Additional Information	Taken from Issue at GitHub since it was observed in a release version (0.237) https://github.com/mamedev/mame/issues/8868
Github Commit

Flags
Regression Version	0.237
Affected Sets / Systems	UI

Attached Files

No.19466 Tafoid Administrator Nov 22, 2021, 23:14	----------------------------------------------------- Exception at EIP=000000014a2259a5 (ui::menu_select_game::get_selection(ui_software_info const&, ui_system_info const&) const+0x0065): ACCESS VIOLATION While attempting to read memory at 00000000000000c8 ----------------------------------------------------- Stack crawl: 0000000000129030: 000000014a2259a5 (ui::menu_select_game::get_selection(ui_software_info const&, ui_system_info const&) const+0x0065) 00000000001292e0: 000000014a864fbc (ui::menu_select_launch::arts_render(float, float, float, float)+0x005c) 00000000001293d0: 000000014a865ce5 (ui::menu_select_launch::draw_right_panel(float, float, float, float)+0x0245) 00000000001295b0: 000000014a866b21 (ui::menu_select_launch::draw(unsigned int)+0x0db1) 00000000001295f0: 000000014a7ebf7b (ui::menu::process(unsigned int, float, float)+0x009b) 00000000001296c0: 000000014a229413 (ui::menu_select_game::handle()+0x0143) 00000000001297d0: 000000014a7ed7ba (ui::menu::do_handle()+0x002a) 0000000000129840: 000000014a7edb55 (ui::menu::ui_handler(render_container&, mame_ui_manager&)+0x0035) 0000000000129870: 000000014a20b163 (std::_Function_handler<unsigned int (render_container&), std::_Bind<unsigned int (*(std::_Placeholder<1>,std::reference_wrapper<mame_ui_manager>))(render_container&, mame_ui_manager&)> >::_M_invoke(std::_Any_data const&, render_container&)+0x0013) 0000000000129980: 000000014a203a5b (mame_ui_manager::update_and_render(render_container&)+0x01bb)
No.19467 Tafoid Administrator Nov 22, 2021, 23:52	With Action binaries, traced first regression commit: https://github.com/mamedev/mame/commit/f1f9992f909a7af2eee7a32d330bd3c20e2c2954 October 14, 2021
No.19468 cuavas Administrator Nov 23, 2021, 00:25	It couldn’t have been caused by f1f9992f909a7af2eee7a32d330bd3c20e2c2954 – it must have happened earlier than that.
No.19469 Tafoid Administrator Nov 23, 2021, 00:57	I downloaded all 3 Action binaries that were to do with the UI work and that was the one that I matched it up with. Perhaps it was in error earlier but that commit exposed it? I dunno. Thanks for fixing, nonetheless.