08189: vanguard: Vanguard 4-way Fire sample cuts off to early during game

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
08189	Sound	Minor	Always	Jan 19, 2022, 21:04	2 days ago

Tester	vidpro1	View Status	Public	Platform	MAME (Official Binary)
Assigned To		Resolution	Open	OS	Windows 10/11 (64-bit)
Status [?]	Confirmed			Driver	snk/snk6502.cpp
Version	0.239	Fixed in Version		Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	08189: vanguard: Vanguard 4-way Fire sample cuts off to early during game
Description	Sound sample fire does not play all the way through.
Steps To Reproduce
Additional Information
Github Commit

Flags
Regression Version	0.226
Affected Sets / Systems	vanguard

Attached Files

No.19707 Tafoid Administrator Jan 21, 2022, 22:04	Probably sound mixing related. 0.226 first binary I hear the difference.
No.22973 125scratch Tester Feb 8, 2025, 20:53	It's not related to the sound mixing, and versions before 0.226 have the issue too. Here's Vanguard in MAME 0.139 with samples, the fire sample noticeably does not play completely. https://files.catbox.moe/5gr2zb.wav And here's some more original arcade footage:
No.23928 vidpro1 Developer 2 days ago edited on: 2 days ago	The else if code is interrupting fire.wav make this change and it works fine matching the ps4 anniversary video. Because the firing sound is not emulated the port handling addressing is cutting off the sample. We could use a newer sample fire.wav - I used to own a Vanguard PCB but not anymore. Remove lines 600 and 601 in snk_6502a.cpp /* play noise samples requested by sound command byte / / SHOT A */ if (data & 0x20 && !(m_last_port1 & 0x20)) m_samples->start(1, 0); //else if (!(data & 0x20) && m_last_port1 & 0x20) // m_samples->stop(1);