Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
08264 Graphics Minor Always Mar 21, 2022, 14:06 Sep 26, 2022, 00:34
Tester ICEknight View Status Public Platform MAME (Official Binary)
Assigned To holub Resolution Fixed OS Windows 10/11 (64-bit)
Status [?] Resolved Driver
Version 0.241 Fixed in Version 0.247 Build 64-bit
Fixed in Git Commit 3e84fa0 Github Pull Request # #10171
Summary MESS-specific 08264: spectrum and clones [darkstar and clones]: Border graphics in Hi-Score table displayed off-center
Description The graphics written to the top border while in the high score table are being considerably shifted to the left, compared to real hardware tests:

Spectrum 48K tests: https://photos.google.com/share/AF1QipNG4DqWvSIieYPol7_WN9vnHn6udJcPgkGcpepl_tBlr1rwzVU2JghLHxorKGE5MQ?key=OENvckF4OU5FRXlKRExuT0Y1bzJkcF8yckZGWFJn

Spectrum 128K +2 tests: https://photos.google.com/share/AF1QipPiXgBk4pyyJIUtEso9Q6i6B4OLu_WiiQwgTJOslqGlBo1huARRe31NSPzCSK7lqQ?key=X2xKU1RHazJOd1V4UFlCNmtPbTIxYTY5MmdNcmZB
Steps To Reproduce Just load the game with LOAD"" and wait for the high score table to show up (may want to speed things up).
-Press J for "LOAD"
-Press Shift+P twice
-Press enter, then F2 to start the cassette (with UI controls enabled)
-Wait until the game loads, stop the tape with Shift+F2, then wait for the scores to show up
Additional Information Observations from geecab, who took the real hardware screenshots:
> On my 48k when running DarkStar, I repeatedly toggled between the menu and hiscore table. The border pattern was mostly in the same place where the yellow border section would begin/align just after the 'k' of the "Dark Star" title. Except for about 1 in 10 times where The yellow border section would begin/align just after the first 'a' of the "Dark Star" title. On my 128k, although the border pattern is naturally skewed, it is always in the same place regardless of how many times I toggle between menu and hiscores. Screenshots of all these scenarios can be found in the albums above.
Github Commit
Flags Verified with Original
Regression Version
Affected Sets / Systems spectrum and clones [darkstar and clones]
Attached Files
png file icon darkstar.png (4,794 bytes) Mar 21, 2022, 14:06 Uploaded by ICEknight
MAME 0.241/2022.03
ICEknight
jpg file icon darkstar48k1.jpg (21,462 bytes) Mar 21, 2022, 14:09 Uploaded by ICEknight
Real hardware, Spectrum 48K
ICEknight
jpg file icon darkstar48k2.jpg (22,465 bytes) Mar 21, 2022, 14:09 Uploaded by ICEknight
Real hardware, Spectrum 48K
ICEknight
png file icon 0002.png (4,854 bytes) Mar 21, 2022, 14:13 Uploaded by ICEknight
MAME 0.241/2022.03 specpls2
ICEknight
jpg file icon darkstar128k1.jpg (20,718 bytes) Mar 21, 2022, 14:16 Uploaded by ICEknight
Real hardware, Spectrum 128K +2
ICEknight
jpg file icon darkstar128k2.jpg (51,850 bytes) Mar 21, 2022, 14:16 Uploaded by ICEknight
Real hardware, Spectrum 128K +2
ICEknight
png file icon spectrum_post_pr9945.png (4,431 bytes) Jun 20, 2022, 23:09 Uploaded by Tafoid
Snapshot from after PR#9945 was applied
Tafoid
jpg file icon darkstar128k3.jpg (143,767 bytes) Jun 21, 2022, 20:43 Uploaded by ICEknight
Real hardware, Spectrum 128K +2
ICEknight
png file icon specpls2_post_pr9945.png (3,789 bytes) Jun 21, 2022, 20:45 Uploaded by ICEknight
Spectrum +2 128K Snapshot from after PR#9945 was applied
ICEknight
jpg file icon paperboy spectrum +2.jpg (85,740 bytes) Jun 21, 2022, 23:52 Uploaded by ICEknight
Real hardware, Spectrum 128K +2
ICEknight
png file icon paperboy mame specpls2.png (4,219 bytes) Jun 21, 2022, 23:52 Uploaded by ICEknight
Spectrum +2 128K Snapshot from after PR#9945 was applied
ICEknight
jpg file icon dark2p.jpg (151,695 bytes) Aug 2, 2022, 00:20 Uploaded by holub
holub
jpg file icon paper2p.jpg (181,644 bytes) Aug 2, 2022, 00:20 Uploaded by holub
holub
Relationships
There are no relationship linked to this issue.
Notes
10
User avatar
No.20326
holub
Tester
Jun 17, 2022, 23:58
That's going to be potential fix if accepted: https://github.com/mamedev/mame/pull/9945
User avatar
No.20336
Tafoid
Administrator
Jun 20, 2022, 23:07
This appears to be fixed and the snap seems to match original hardware for the "spectrum" test case (spectrum48k1.jpg).
Can you confirm this ICEKnight?
User avatar
No.20337
ICEknight
Tester
Jun 21, 2022, 11:29
edited on: Jun 21, 2022, 11:36
I need to test on real hardware since the shape on the +2 is now correct but seems to be somewhat shifted to the left, in comparison with the existing picture (which could be the random shifting that was talked about but maybe not):
Current build: https://i.imgur.com/oN4UXuy.png
Real hardware: https://i.imgur.com/MA3eULc.png
User avatar
No.20340
ICEknight
Tester
Jun 21, 2022, 20:41
edited on: Jun 21, 2022, 21:55
Just tested different versions of it on my +2 and I'm always getting the same amount of shifting seen in the pics, so MAME currently seems to be shifting the figure exactly 8 pixels too much to the left: https://i.imgur.com/KB0Khvm.jpg

Haven't yet seen the random shift that happened in darkstar48k2.jpg, must be very rare to trigger or exclusive to 48K models.
User avatar
No.20342
ICEknight
Tester
Jun 21, 2022, 23:50
I've just found out that the same exact thing happens in Paperboy. MAME displays the distorted figure 8 pixels more to the left than real hardware.

Spectrum +2: https://i.imgur.com/8kIRBTF.jpg
MAME specpls2: https://i.imgur.com/Qq0MbKy.png
User avatar
No.20343
holub
Tester
Jun 22, 2022, 18:39
Ok. Let's keep that one for a while. I'll try to adjust the shift of border in +2 model.
User avatar
No.20423
holub
Tester
Aug 2, 2022, 00:19
#10171 fixed for 2+
User avatar
No.20428
ICEknight
Tester
Aug 4, 2022, 19:07
Both games seem to indeed display the graphics like real hardware with the current changes, even the garbled 128K ones.
User avatar
No.20567
ICEknight
Tester
Sep 25, 2022, 20:46
This can be marked as Resolved.
User avatar
No.20568
Robbbert
Senior Tester
Sep 26, 2022, 00:30
edited on: Sep 26, 2022, 00:34
Resolved as requested.