Viewing Issue Advanced Details
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
08475 Misc. Critical (emulator) Always Nov 2, 2022, 23:13 31 days ago
Tester Firewave View Status Public Platform MAME (Self-compiled)
Assigned To hap Resolution Fixed OS Linux (64-bit)
Status [?] Resolved Driver
Version 0.249 Fixed in Version 0.250 Build 64-bit
Fixed in Git Commit c3686f3 Github Pull Request #
Summary 08475: igs/* sets using ics2115_device: AddressSanitizer: heap-buffer-overflow
Description Output for ddp2:

=================================================================
==12708==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x62800015c7ee at pc 0x7ff90d88eef8 bp 0x7ffff6d106b0 sp 0x7ffff6d106a8
READ of size 2 at 0x62800015c7ee thread T0
    #0 0x7ff90d88eef7 in ics2115_device::fill_output(ics2115_device::ics2115_voice&, std::vector<write_stream_view, std::allocator<write_stream_view> >&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/devices/sound/ics2115.cpp:440:35
    #1 0x7ff90d88f0b3 in ics2115_device::sound_stream_update(sound_stream&, std::vector<read_stream_view, std::allocator<read_stream_view> > const&, std::vector<write_stream_view, std::allocator<write_stream_view> >&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/devices/sound/ics2115.cpp:492:7
    #2 0x7ff90d88f8af in non-virtual thunk to ics2115_device::sound_stream_update(sound_stream&, std::vector<read_stream_view, std::allocator<read_stream_view> > const&, std::vector<write_stream_view, std::allocator<write_stream_view> >&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/devices/sound/ics2115.cpp
    #3 0x7ff9173f2f6d in util::detail::delegate_base<delegate_late_bind, void, sound_stream&, std::vector<read_stream_view, std::allocator<read_stream_view> > const&, std::vector<write_stream_view, std::allocator<write_stream_view> >&>::operator()(sound_stream&, std::vector<read_stream_view, std::allocator<read_stream_view> > const&, std::vector<write_stream_view, std::allocator<write_stream_view> >&) const /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/lib/util/delegate.h:765:11
    #4 0x7ff9173e4f0e in sound_stream::update_view(attotime, attotime, unsigned int) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/sound.cpp:749:4
    #5 0x7ff9173e3bdf in sound_stream_input::update(attotime, attotime) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/sound.cpp:522:25
    #6 0x7ff9173e4aa1 in sound_stream::update_view(attotime, attotime, unsigned int) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/sound.cpp:735:49
    #7 0x7ff9173e3bdf in sound_stream_input::update(attotime, attotime) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/sound.cpp:522:25
    #8 0x7ff9173e4aa1 in sound_stream::update_view(attotime, attotime, unsigned int) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/sound.cpp:735:49
    #9 0x7ff9173fa9b8 in speaker_device::mix(float*, float*, attotime, attotime, int, bool) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/speaker.cpp:70:42
    #10 0x7ff9173ee54b in sound_manager::update(int) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/sound.cpp:1511:11
    #11 0x7ff91736d304 in operator() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/lib/util/delegate.h:765:11
    #12 0x7ff91736d304 in device_scheduler::execute_timers() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/schedule.cpp:951:5
    #13 0x7ff917368858 in device_scheduler::timeslice() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/schedule.cpp:505:2
    #14 0x7ff9172004a7 in running_machine::run(bool) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/machine.cpp:329:17
    #15 0x7ff91a366f7f in mame_machine_manager::execute() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/frontend/mame/mame.cpp:290:19
    #16 0x7ff91a55b8d6 in cli_frontend::start_execution(mame_machine_manager*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/frontend/mame/clifront.cpp:275:22
    #17 0x7ff91a55f41f in cli_frontend::execute(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/frontend/mame/clifront.cpp:291:3
    #18 0x7ff91a36bd5f in emulator_info::start_frontend(emu_options&, osd_interface&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/frontend/mame/mame.cpp:454:18
    #19 0x7ff91754258b in main /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/osd/sdl/sdlmain.cpp:191:9
    #20 0x7ff8d5a49209 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #21 0x7ff8d5a492bb in __libc_start_main csu/../csu/libc-start.c:389:3
    #22 0x7ff8f4ccc260 in _start (/mnt/s/GitHub/mame/mame+0x1d397260) (BuildId: 603d3d1c300651feb2a8e3ac6e9cb58d3f85e77b)

Address 0x62800015c7ee is a wild pointer inside of access range of size 0x000000000002.
SUMMARY: AddressSanitizer: heap-buffer-overflow /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/devices/sound/ics2115.cpp:440:35 in ics2115_device::fill_output(ics2115_device::ics2115_voice&, std::vector<write_stream_view, std::allocator<write_stream_view> >&)
Shadow bytes around the buggy address:
  0x0c50800238a0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c50800238b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c50800238c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c50800238d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c50800238e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x0c50800238f0: fa fa fa fa fa fa fa fa fa fa fa fa fa[fa]fa fa
  0x0c5080023900: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c5080023910: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c5080023920: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c5080023930: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c5080023940: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==12708==ABORTING


Possibly caused by
../../../../../src/devices/sound/ics2115.cpp:440:35: runtime error: index 65527 out of bounds for type 'u16[4096]' (aka 'unsigned short[4096]')
Steps To Reproduce
Additional Information Some affected sets (there's way more):

igs/pgm.cpp
ddp2
ddp2100c
ddp2100hk
ddp2100j
ddp2100k
ddp2100t
ddp2101
ddp2101c
ddp2101hk
ddp2101j
ddp2101k
ddp2101t
ddp2c
ddp2hk
ddp2j
ddp2k
ddp2t
ddp3
ddpdoj

igs/igs011.cpp
vbowl
vbowlhk
vbowlj
Github Commit
Flags
Regression Version
Affected Sets / Systems igs/* sets using ics2115_device
Attached Files
 
Relationships
There are no relationship linked to this issue.
Notes
1
User avatar
No.20774
hap
Developer
31 days ago
probably fixed here: https://github.com/mamedev/mame/commit/c3686f3cde226e5b3084ecdaccc345f1ae9a803f