Viewing Issue Advanced Details
[ Jump to Notes ]
atari/copsnrob.cpp
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
08493 Misc. Critical (emulator) Always Nov 4, 2022, 14:00 Nov 4, 2022, 23:01
Tester Firewave View Status Public Platform MAME (Self-compiled)
Assigned To hap Resolution Fixed OS Linux (64-bit)
Status [?] Resolved Driver
atari/copsnrob.cpp
Version 0.249 Fixed in Version 0.250 Build 64-bit
Fixed in Git Commit af44058 Github Pull Request #
Summary 08493: copsnrob: AddressSanitizer: heap-buffer-overflow
Description 
==11209==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6190000aea80 at pc 0x7fbbec7fd19f bp 0x7fffc61e5f50 sp 0x7fffc61e5f48
READ of size 1 at 0x6190000aea80 thread T0
    #0 0x7fbbec7fd19e in copsnrob_state::screen_update_copsnrob(screen_device&, bitmap_ind16&, rectangle const&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/mame/atari/copsnrob_v.cpp:23:5
    #1 0x7fbc0dcc556d in util::detail::delegate_base<delegate_late_bind, unsigned int, screen_device&, bitmap_ind16&, rectangle const&>::operator()(screen_device&, bitmap_ind16&, rectangle const&) const /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/lib/util/delegate.h:765:11
    #2 0x7fbc0dcb5386 in screen_device::update_partial(int) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/screen.cpp:1215:41
    #3 0x7fbc0ddb2bc9 in video_manager::finish_screen_updates() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/video.cpp:622:10
    #4 0x7fbc0ddb19cb in video_manager::frame_update(bool) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/video.cpp:215:44
    #5 0x7fbc0dcab7c8 in screen_device::vblank_begin(int) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/screen.cpp:1646:21
    #6 0x7fbc0dc94304 in operator() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/lib/util/delegate.h:765:11
    #7 0x7fbc0dc94304 in device_scheduler::execute_timers() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/schedule.cpp:951:5
    #8 0x7fbc0dc8f858 in device_scheduler::timeslice() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/schedule.cpp:505:2
    #9 0x7fbc0db274a7 in running_machine::run(bool) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/machine.cpp:329:17
    #10 0x7fbc10c8df7f in mame_machine_manager::execute() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/frontend/mame/mame.cpp:290:19
    #11 0x7fbc10e828d6 in cli_frontend::start_execution(mame_machine_manager*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/frontend/mame/clifront.cpp:275:22
    #12 0x7fbc10e8641f in cli_frontend::execute(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/frontend/mame/clifront.cpp:291:3
    #13 0x7fbc10c92d5f in emulator_info::start_frontend(emu_options&, osd_interface&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/frontend/mame/mame.cpp:454:18
    #14 0x7fbc0de6958b in main /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/osd/sdl/sdlmain.cpp:191:9
    #15 0x7fbbcc369209 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #16 0x7fbbcc3692bb in __libc_start_main csu/../csu/libc-start.c:389:3
    #17 0x7fbbeb5f3260 in _start (/mnt/s/GitHub/mame/mame+0x1d397260) (BuildId: 603d3d1c300651feb2a8e3ac6e9cb58d3f85e77b)

0x6190000aea80 is located 0 bytes to the right of 1024-byte region [0x6190000ae680,0x6190000aea80)
allocated by thread T0 here:
    #0 0x7fbbeb6760ae in __interceptor_malloc (/mnt/s/GitHub/mame/mame+0x1d41a0ae) (BuildId: 603d3d1c300651feb2a8e3ac6e9cb58d3f85e77b)
    #1 0x7fbc074bd3f9 in memory_manager::allocate_memory(device_t&, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, unsigned char, unsigned long) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/emumem.cpp:312:46
    #2 0x7fbc074be255 in memory_manager::share_alloc(device_t&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, unsigned char, unsigned long, util::endianness) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/emumem.cpp:378:14
    #3 0x7fbc075083be in address_space::prepare_map_generic(address_map&, bool) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/emumem_aspace.cpp:809:23
    #4 0x7fbc0750ad62 in address_space::prepare_map() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/emumem_aspace.cpp:896:2
    #5 0x7fbc074e43b7 in device_memory_interface::prepare_maps() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/dimemory.h:102:84
    #6 0x7fbc074bcb1a in memory_manager::initialize() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/emumem.cpp:293:11
    #7 0x7fbc0db23bf5 in running_machine::start() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/machine.cpp:183:11
    #8 0x7fbc0db270dc in running_machine::run(bool) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/emu/machine.cpp:281:3
    #9 0x7fbc10c8df7f in mame_machine_manager::execute() /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/frontend/mame/mame.cpp:290:19
    #10 0x7fbc10e828d6 in cli_frontend::start_execution(mame_machine_manager*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/frontend/mame/clifront.cpp:275:22
    #11 0x7fbc10e8641f in cli_frontend::execute(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/frontend/mame/clifront.cpp:291:3
    #12 0x7fbc10c92d5f in emulator_info::start_frontend(emu_options&, osd_interface&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&) /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/frontend/mame/mame.cpp:454:18
    #13 0x7fbc0de6958b in main /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/osd/sdl/sdlmain.cpp:191:9
    #14 0x7fbbcc369209 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16

SUMMARY: AddressSanitizer: heap-buffer-overflow /mnt/s/GitHub/mame/build/projects/sdl/mame/gmake-linux-clang/../../../../../src/mame/atari/copsnrob_v.cpp:23:5 in copsnrob_state::screen_update_copsnrob(screen_device&, bitmap_ind16&, rectangle const&)
Shadow bytes around the buggy address:
  0x0c328000dd00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c328000dd10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c328000dd20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c328000dd30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c328000dd40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c328000dd50:[fa]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c328000dd60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c328000dd70: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c328000dd80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c328000dd90: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c328000dda0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
Steps To Reproduce
Additional Information
Github Commit
Flags
Regression Version
Affected Sets / Systems copsnrob
Attached Files
  
Relationships
There are no relationship linked to this issue.
Notes
3
User avatar
No.20702
Firewave
Senior Tester
Nov 4, 2022, 15:17
 From copsnrob_state::screen_update_copsnrob():

for (int offs = m_videoram.bytes(); offs >= 0; offs--)
{
...
				m_videoram[offs] & 0x3f,0,
...
}

The start index is obviously out of bounds since the maximum index is actually "bytes()-1".
User avatar
No.20713
hap
Developer
Nov 4, 2022, 19:24
 Right, fixed here: https://github.com/mamedev/mame/commit/af440587a3bb71b71509e9db055c9ec99413291c
Like with calorie, please assign to Firewave if crash is fixed.
User avatar
No.20720
Firewave
Senior Tester
Nov 4, 2022, 23:01
 Cherry-picked and fix confirmed.