Viewing Issue Advanced Details
[ Jump to Notes ]
commodore/c128.cpp
ID Category [?] Severity [?] Reproducibility Date Submitted Last Update
08581 Timing Critical (emulation) Always Mar 17, 2023, 21:52 Mar 24, 2023, 10:48
Tester Walker View Status Public Platform MAME (Official Binary)
Assigned To Resolution Open OS Windows 10/11 (64-bit)
Status [?] Confirmed Driver
commodore/c128.cpp
Version 0.251 Fixed in Version Build 64-bit
Fixed in Git Commit Github Pull Request #
Summary 08581: c128 All PAL versions: The PAL versions produce wrong output with the rs232 device, NTSC devices produce correct output
Description When Data is ouput through the rs232 Device, on the PAL device versions some bytes arrive with wrong values.
The wrong bytes are reproducible values from 0x20-0xdf, the range 0x00-0x1f and 0xe0-0xff arrive with correct values.
Steps To Reproduce Starting the device with rs232 user prort device attached
Example Command line to start :
mame c128dp -w -user rs232 -user:rs232:rs232 printer -printout out128_pal_bug.bin
set rs232 hardware configuration to 1200 baud, 8bit, no parity, 1 stop bit

Then run the following BASIC snippet (error appears both in 128 and c64 mode, the Basic snippet is valid for both modes):
The missing spaces are valid in commodore basic and not a typo, if you prefer you can add them for readability.

OPEN5,2,0,CHR$(8):REM redundant setting interface to 1200 baud etc
FORI=0TO255:PRINT#5,CHR$(I);:NEXT
CLOSE5

Now close the device, the file out128_pal_bug.bin now contains:

hexdump -C out128_pal_bug.bin
00000000 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f |................|
00000010 10 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f |................|
00000020 60 61 62 63 64 65 66 67 68 69 6a 6b 6c 6d 6e 6f |`abcdefghijklmno|
00000030 70 71 72 73 74 75 76 77 78 79 7a 7b 7c 7d 7e 7f |pqrstuvwxyz{|}~.|
00000040 80 81 82 83 84 85 86 87 88 89 8a 8b 8c 8d 8e 8f |................|
00000050 90 91 92 93 94 95 96 97 98 99 9a 9b 9c 9d 9e 9f |................|
00000060 e0 e1 e2 e3 e4 e5 e6 e7 e8 e9 ea eb ec ed ee ef |................|
00000070 f0 f1 f2 f3 f4 f5 f6 f7 f8 f9 fa fb fc fd fe ff |................|
00000080 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f |................|
00000090 10 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f |................|
000000a0 60 61 62 63 64 65 66 67 68 69 6a 6b 6c 6d 6e 6f |`abcdefghijklmno|
000000b0 70 71 72 73 74 75 76 77 78 79 7a 7b 7c 7d 7e 7f |pqrstuvwxyz{|}~.|
000000c0 80 81 82 83 84 85 86 87 88 89 8a 8b 8c 8d 8e 8f |................|
000000d0 90 91 92 93 94 95 96 97 98 99 9a 9b 9c 9d 9e 9f |................|
000000e0 e0 e1 e2 e3 e4 e5 e6 e7 e8 e9 ea eb ec ed ee ef |................|
000000f0 f0 f1 f2 f3 f4 f5 f6 f7 f8 f9 fa fb fc fd fe ff |................|
Additional Information All c128(d) NTSC devices return the correct values:

hexdump -C out128_correct.bin
00000000 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f |................|
00000010 10 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f |................|
00000020 20 21 22 23 24 25 26 27 28 29 2a 2b 2c 2d 2e 2f | !"#$%&'()*+,-./|
00000030 30 31 00 33 34 35 36 37 38 39 3a 3b 3c 3d 3e 3f |01.3456789:;<=>?|
00000040 40 41 42 43 44 45 46 47 48 49 4a 4b 4c 4d 4e 4f |@ABCDEFGHIJKLMNO|
00000050 50 51 52 53 54 55 56 57 58 59 5a 5b 5c 5d 5e 5f |PQRSTUVWXYZ[\]^_|
00000060 60 61 62 63 64 65 66 67 68 69 6a 6b 6c 6d 6e 6f |`abcdefghijklmno|
00000070 70 71 72 73 74 75 76 77 78 79 7a 7b 7c 7d 7e 7f |pqrstuvwxyz{|}~.|
00000080 80 81 82 83 84 85 86 87 88 89 8a 8b 8c 8d 8e 8f |................|
00000090 90 91 92 93 94 95 96 97 98 99 9a 9b 9c 9d 9e 9f |................|
000000a0 a0 a1 a2 a3 a4 a5 a6 a7 a8 a9 aa ab ac ad ae af |................|
000000b0 b0 b1 b2 b3 b4 b5 b6 b7 b8 b9 ba bb bc bd be bf |................|
000000c0 c0 c1 c2 c3 c4 c5 c6 c7 c8 c9 ff cb cc cd ce cf |................|
000000d0 d0 d1 d2 d3 d4 d5 d6 d7 d8 d9 da db dc dd de df |................|
000000e0 e0 e1 e2 e3 e4 e5 e6 e7 e8 e9 ea eb ec ed ee ef |................|
000000f0 f0 f1 f2 f3 f4 f5 f6 f7 f8 f9 fa fb fc fd fe ff |
Github Commit
Flags
Regression Version
Affected Sets / Systems c128 All PAL versions
Attached Files
  
Relationships
There are no relationship linked to this issue.
Notes
3
User avatar
No.21178
Walker
Tester
Mar 18, 2023, 11:22
edited on: Mar 19, 2023, 16:02
 oldest MAME version tested is 0.236 also shows this bug
For completeness - Testing in MAME 0.252 shows exact same behaviour (as expected).
User avatar
No.21195
Robbbert
Senior Tester
Mar 24, 2023, 00:53
 I only tried the PAL version exactly as you described, and the bug is there.

To clarify, "set rs232 hardware configuration" means go into Machine Configuration.
"Now close the device" means to go into the File Manager, and unload the bin file.
User avatar
No.21200
Walker
Tester
Mar 24, 2023, 10:48
edited on: Mar 24, 2023, 10:53
 yes machine configuration menu, i did not know a cmd line to give the settings at start (though probably something exists to pass settings there?), but it is important to set the baud rate there plus to pass the correct configuration in the open statement in basic (open5,2,0,chr$(8) selects 1200 baud 8n1 there for rs232 device, i tested down to 300 baud with same result [values output differ])

And with "Now close the device" I actually meant closing mame