08610: nss_ncaa, nss_lwep: After running these games one after the other, a crash may result

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
08610	Crash/Freeze	Minor	Random	Apr 24, 2023, 15:29	May 2, 2023, 08:11

Tester	Robbbert	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	Open	OS	Windows 10/11 (64-bit)
Status [?]	Acknowledged			Driver	nintendo/nss.cpp
Version	0.253	Fixed in Version		Build	64-bit
		Fixed in Git Commit		Github Pull Request #

Summary	08610: nss_ncaa, nss_lwep: After running these games one after the other, a crash may result
Description	These 2 games, both marked as not working, if played one after the other will eventually cause a crash. It was first noticed on one of my builds by crashing, so the current git of MAME was used to confirm it (pretty much what will be in 0.254).
Steps To Reproduce	Start MAME by going into the UI. Type nss, you'll see the 2 games concerned in the centre of the screen. Choose one of them, it will seem to work. After a short while press Esc to return to the menu. Type nss again (menu doesn't remember it from before). Choose the other game, let it run a little while as before. After swapping between them a few times you may randomly get a crash. ----------------------------------------------------- Exception at EIP=00007ff70327f22f (m50458_device::screen_update(screen_device&, bitmap_rgb32&, rectangle const&)+0x046f): ACCESS VIOLATION While attempting to write memory at 0000016c0523b280 ----------------------------------------------------- RAX=fffffffffffd7484 RBX=0000000000000017 RCX=0000000000000000 RDX=0000016c052de070 RSI=0000000000000005 RDI=0000000000000000 RBP=0000016c036f03a0 RSP=00000042cd339280 R8=0000000000000001 R9=0000000000000000 R10=0000000000000004 R11=000000000000002f R12=0000000000000000 R13=0000016c011efea8 R14=00000000fffffdb7 R15=00000000fffffde6 ----------------------------------------------------- Stack crawl: 00000042cd339340: 00007ff70327f22f (m50458_device::screen_update(screen_device&, bitmap_rgb32&, rectangle const&)+0x046f) 00000042cd339370: 00007ff6feb09fe0 ((anonymous namespace)::nss_state::screen_update(screen_device&, bitmap_rgb32&, rectangle const&)+0x0010) 00000042cd339410: 00007ff7009efd90 (screen_device::update_partial(int)+0x0290) 00000042cd339470: 00007ff70407e093 (video_manager::finish_screen_updates()+0x00c3) 00000042cd339500: 00007ff704080108 (video_manager::frame_update(bool)+0x01f8) 00000042cd339570: 00007ff7009ed623 (screen_device::vblank_begin(int)+0x0233) 00000042cd3395e0: 00007ff700a05f5b (device_scheduler::timeslice()+0x014b) 00000042cd339760: 00007ff700a0313f (running_machine::run(bool)+0x01bf) 00000042cd33ec90: 00007ff703ed6e6b (mame_machine_manager::execute()+0x024b) 00000042cd33f080: 00007ff707c3fc66 (cli_frontend::start_execution(mame_machine_manager*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&)+0x03e6) 00000042cd33f360: 00007ff707c4028b (cli_frontend::execute(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)+0x007b) 00000042cd33f3c0: 00007ff703ed1629 (emulator_info::start_frontend(emu_options&, osd_interface&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)+0x0029) 00000042cd33f780: 00007ff708e603f3 (luaopen_lfs+0xb603f3) 00000042cd33f850: 00007ff6fc3713b1 (__tmainCRTStartup+0x0231) 00000042cd33f880: 00007ff6fc3714e6 (mainCRTStartup+0x0016) 00000042cd33f8b0: 00007ffcac477604 (BaseThreadInitThunk+0x0014) 00000042cd33f930: 00007ffcad2626a1 (RtlUserThreadStart+0x0021)
Additional Information	Even though they are marked as not working, they should not crash like this.
Github Commit

Flags
Regression Version
Affected Sets / Systems	nss_ncaa, nss_lwep

Attached Files

No.21346 hap Developer Apr 24, 2023, 16:25	I'm getting random hard locks, not crashes.
No.21349 Robbbert Senior Tester Apr 24, 2023, 22:55 edited on: Apr 24, 2023, 22:56	Seems better today with your changes. If it's fixed for you, you may resolve this or let me know. I won't be able to test it in my other build until after the release of 254.
No.21350 hap Developer Apr 25, 2023, 13:47	It's not fixed for me
No.21353 Tafoid Administrator Apr 25, 2023, 17:26 edited on: Apr 25, 2023, 18:01	haven't tested - but is this some multi-session thing?
No.21388 Robbbert Senior Tester May 2, 2023, 08:11	Just tried now, firstly nss_lwep, ok then nss_ncaa, ok, then nss_lwep - it froze at the red warning screen. Even esc doesn't work, but windows isn't complaining of not responding. Clicking on X did nothing too. So I went back to the mame cmd prompt and pressed Ctrl C - this worked. IMO nss_lwep seems to be the culprit.