| ID | Category [?] | Severity [?] | Reproducibility | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 09314 | Graphics | Minor | Always | 11 days ago | 2 days ago |
| Tester | motomachi16 | View Status | Public | Platform | MAME (Official Binary) |
| Assigned To | Resolution | Open | OS | Windows (x64) | |
| Status [?] | Acknowledged | Driver | |||
| Version | 0.283 | Fixed in Version | Build | x64 | |
| Fixed in Git Commit | Github Pull Request # | ||||
| Summary | 09314: galivan and clones: Background priorities have not been implemented. | ||||
| Description | Gallivan's background seems to have similar color based priorities to Mighty Guy's. | ||||
| Steps To Reproduce | |||||
| Additional Information | |||||
| Github Commit | |||||
| Flags | Verified with Original | ||||
| Regression Version | |||||
| Affected Sets / Systems | galivan and clones | ||||
|
Attached Files
|
| ||||
|
| |||||
From the actual streaming video
| |||||
From the actual streaming video
| |||||
Image after fix
| |||||
Image after fix
| |||||
 No.23859
motomachi16 Tester
11 days ago
|
Streaming URL https://www.youtube.com/live/Loicg9NK43Q?si=CTT1R-2kIcZLnNaV&t=5968 |
|---|---|
|
No.23860
motomachi16 Tester
11 days ago
|
I copied the Mighty Guy processing myself and tested it, and it seems to reproduce the processing of the actual machine. TILE_GET_INFO_MEMBER(galivan_state::get_bg_tile_info) { int const attr = m_bgrom[tile_index + 0x4000]; int const code = m_bgrom[tile_index] | ((attr & 0x03) << 8); tileinfo.set(1, code, (attr & 0x78) >> 3, // seems correct 0); // same as Mighty Guy tileinfo.group = (attr & 0x80) >> 7; } void galivan_state::video_start() { m_bg_tilemap = &machine().tilemap().create(*m_gfxdecode, tilemap_get_info_delegate(*this, FUNC(galivan_state::get_bg_tile_info)), TILEMAP_SCAN_ROWS, 16, 16, 128, 128); m_tx_tilemap = &machine().tilemap().create(*m_gfxdecode, tilemap_get_info_delegate(*this, FUNC(galivan_state::get_tx_tile_info)), TILEMAP_SCAN_COLS, 8, 8, 32, 32); m_tx_tilemap->set_transparent_pen(15); // same as Mighty Guy m_bg_tilemap->set_transmask(0, 0xffff, 0x0000); // split type 0 is totally transparent in front half m_bg_tilemap->set_transmask(1, 0x0fff, 0xf000); // split type 1 has pens 0-11 transparent in front half } |
|
No.23882
motomachi16 Tester
2 days ago
|
The following fixes were missing: void galivan_state::draw_sprites(bitmap_ind16 &bitmap, const rectangle &cliprect) { uint8_t const *buffered_spriteram = m_spriteram->buffer(); int const length = m_spriteram->bytes(); int const flip = flip_screen(); gfx_element *gfx = m_gfxdecode->gfx(2); int const mask = (gfx->elements()-1) & ~0xff; // draw the sprites for (int offs = 0; offs < length; offs += 4) { int const attr = buffered_spriteram[offs + 2]; int const code = buffered_spriteram[offs + 1] + ((attr << 7) & mask); int const color = (attr & 0x3c) >> 2; int flipx = attr & 0x40; int flipy = attr & 0x80; int sx = (buffered_spriteram[offs + 3] - 0x80) + 256 * (attr & 0x01); int sy = 240 - buffered_spriteram[offs]; if (flip) { sx = 240 - sx; sy = 240 - sy; flipx = !flipx; flipy = !flipy; } gfx->transmask(bitmap, cliprect, code, color + 16 * (m_sprpalbank[code >> 2] & 0x0f), flipx, flipy, sx, sy, m_palette->transpen_mask(*gfx, color, 0x8f)); // fix } } |