09383: tourtabl, tourtab2: Can't move paddle

ID	Category [?]	Severity [?]	Reproducibility	Date Submitted	Last Update
09383	DIP/Input	Major	Always	21 hours ago	17 hours ago

Tester	Robbbert	View Status	Public	Platform	MAME (Self-compiled)
Assigned To		Resolution	Invalid report	OS	Windows (x64)
Status [?]	Closed			Driver	atari/tourtabl.cpp
Version	0.285	Fixed in Version		Build	x64
		Fixed in Git Commit		Github Pull Request #

Summary	09383: tourtabl, tourtab2: Can't move paddle
Description	These games are marked as working, but they have never worked for me. Can coin up and start game, but then unable to move the paddle. Tried all the keys listed in the inputs tab, but none worked.
Steps To Reproduce	>mame tourtabl (or tourtab2) Insert coin, start game. Breakout starts up. The listed keys are Left and Right, but the paddle won't move. Soon the ball will launch, and watch it pass by. Game seems unplayable.
Additional Information
Github Commit

Flags	Regression
Regression Version	0.257
Affected Sets / Systems	tourtabl, tourtab2

Attached Files	Screenshot (859).png (485,869 bytes) 18 hours ago Uploaded by hap

No.24110 hap Developer 18 hours ago edited on: 18 hours ago	There wasn't any bug. All other games will have wrong controls if the inputs order is reversed. Breakout being on P3 & P4 paddles is on purpose by Atari. In other words: 0.257 had a bugfix, not a regression.
No.24111 Robbbert Moderator 17 hours ago edited on: 17 hours ago	So, the reason it didn't work, even though I tried all the keys, is because nothing is assigned to player 4's controls. Not exactly intuitive. Also, the picture says that player one should use players 3's control for breakout, but in MAME you must use player 4's controls, so I still think something's wrong.
No.24112 hap Developer 17 hours ago	The picture says Breakout P1 (single player control) uses P4 controls. I added P4 analog directional defaults here: https://github.com/mamedev/mame/commit/6a1860e4203908da9d2121fce4ecef61766018c6 - P4 digital joystick controls was already on numpad 2,4,6,8. Analog defaults were missing.