- --
Viewing Issue Advanced Details
ID | Category [?] | Severity [?] | Reproducibility | Date Submitted | Last Update |
---|---|---|---|---|---|
03768 | Graphics | Minor | Always | Mar 6, 2010, 22:19 | Apr 22, 2010, 18:55 |
Tester | M.A.S.H. | View Status | Public | Platform | MAME (Self-compiled) |
Assigned To | Resolution | Fixed | OS | Windows XP (32-bit) | |
Status [?] | Resolved | Driver | |||
Version | 0.136u4 | Fixed in Version | 0.137u2 | Build | Normal |
Fixed in Git Commit | Github Pull Request # | ||||
Summary | 03768: All sets in cidelsa.c, most sets in astrocde.c: Shifted gfx display | ||||
Description |
The screen/gfx are shifted in the astrocde.c and cidelsa.c games since MAME 0.136u3. The bottom is cut off. Compare the attached two screenshots of MAME 0.136u2 and 0.136u3 taken with IrfanView and MAME seawolf2 -window. The MAME snapshots of both version are looking normal. |
||||
Steps To Reproduce | |||||
Additional Information |
astrocde.c -------------- seawolf2 spacezap ebases robby demndrgn profpac tenpindx |
||||
Github Commit | |||||
Flags | |||||
Regression Version | 0.136u3 | ||||
Affected Sets / Systems | All sets in cidelsa.c, most sets in astrocde.c | ||||
Attached Files
|
seawolf2-Comapre-0136u2-0136u3.gif (33,506 bytes) Mar 6, 2010, 23:59
| ||||
destryer_Comapre-0136u2-0136u3.gif (20,866 bytes) Mar 7, 2010, 10:55
| |||||
astrocde-cidelsa.diff (1,729 bytes) Mar 8, 2010, 22:44 [Show Content] [Hide Content]diff -Nru old/src/mame/drivers/astrocde.c new/src/mame/drivers/astrocde.c --- old/src/mame/drivers/astrocde.c 2010-02-14 22:40:38.000000000 +0100 +++ new/src/mame/drivers/astrocde.c 2010-03-08 23:00:06.000000000 +0100 @@ -1284,7 +1284,7 @@ MDRV_SCREEN_ADD("screen", RASTER) MDRV_SCREEN_FORMAT(BITMAP_FORMAT_INDEXED16) MDRV_SCREEN_RAW_PARAMS(ASTROCADE_CLOCK, 455, 0, 352, 262, 0, 240) - MDRV_SCREEN_DEFAULT_POSITION(1.1, 0.0, 1.18, -0.018) /* clip out borders */ + MDRV_SCREEN_DEFAULT_POSITION(1.1, -0.05, 1.182, -0.110) /* clip out borders */ MDRV_PALETTE_INIT(astrocde) MDRV_VIDEO_START(astrocde) diff -Nru old/src/mame/video/cidelsa.c new/src/mame/video/cidelsa.c --- old/src/mame/video/cidelsa.c 2010-01-28 13:14:18.000000000 +0100 +++ new/src/mame/video/cidelsa.c 2010-03-08 23:29:04.000000000 +0100 @@ -254,7 +254,7 @@ MACHINE_DRIVER_START( destryer_video ) MDRV_CDP1869_SCREEN_PAL_ADD(SCREEN_TAG, DESTRYER_CHR2) - MDRV_SCREEN_DEFAULT_POSITION(1.226, 0.012, 1.4, 0.044) + MDRV_SCREEN_DEFAULT_POSITION(1.226, -0.102, 1.4, 0.244) MDRV_VIDEO_START(cidelsa) MDRV_VIDEO_UPDATE(cidelsa) @@ -266,7 +266,7 @@ MACHINE_DRIVER_START( altair_video ) MDRV_CDP1869_SCREEN_PAL_ADD(SCREEN_TAG, ALTAIR_CHR2) - MDRV_SCREEN_DEFAULT_POSITION(1.226, 0.012, 1.4, 0.044) + MDRV_SCREEN_DEFAULT_POSITION(1.226, -0.102, 1.4, 0.244) MDRV_VIDEO_START(cidelsa) MDRV_VIDEO_UPDATE(cidelsa) @@ -278,7 +278,7 @@ MACHINE_DRIVER_START( draco_video ) MDRV_CDP1869_SCREEN_PAL_ADD(SCREEN_TAG, DRACO_CHR2) - MDRV_SCREEN_DEFAULT_POSITION(1.226, 0.012, 1.360, 0.024) + MDRV_SCREEN_DEFAULT_POSITION(1.226, -0.102, 1.360, 0.204) MDRV_VIDEO_START(draco) MDRV_VIDEO_UPDATE(cidelsa) | |||||
Relationships
There are no relationship linked to this issue. |
Notes
5
No.05838
Tafoid Administrator
Mar 6, 2010, 22:52
|
I'd suggest if you can to make the screenshot top/bottom rather than side to side... or even separate shots. Thank you. |
---|---|
No.05839
M.A.S.H. Senior Tester
Mar 7, 2010, 00:00
|
Added an animated GIF file from both version. |
No.05840
Tafoid Administrator
Mar 7, 2010, 01:39
|
That's fine. I just didn't dig having to scroll left/right on a bug :) Thank you. |
No.05846
M.A.S.H. Senior Tester
Mar 8, 2010, 22:44
edited on: Mar 8, 2010, 22:46 |
Fixed the problem with the shifted screen display. In MAME 0.136u2 was emu\render.c changed with the new value no_center (center the container), so the MDRV_SCREEN_DEFAULT_POSITION in the drivers astrocde and cidelsa must updated. Use attached diff file to changed both drivers. Delete the cfg files before you tested them!!! I have submit the fix for next release. |
No.05992
Tafoid Administrator
Apr 22, 2010, 18:55
|
Fixed effective 0.137u2, although I'm not sure what change brought about the fix. I think it was the render.c fixes by Bryan Ischo. |